Added Rosenbrock methods #2278
Closed
Added Rosenbrock methods #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisRackauckas how can I include rodas5p and rosenbrock23 in ordinarydiffeqdefault? I have shifted them to Ordinarydiffeqrosenbrock |
OrdinaryDiffEqDefault will need to depend on those two. Keep those two separate, they will be separated in order to improve their load times as they are workhorse methods. For now simply don't move them. |
|
@ChrisRackauckas Should I start a new PR and close this one ?? I think there are a few more things to fix here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.
solves a part of #2177