Added Verner Methods #2274
Added Verner Methods #2274
Conversation
|
@ChrisRackauckas Should I also shift Tsit, BS5, AutoVern methods to the OrdinaryDiffEqVerner lib ?? They are almost always defined together in some files |
|
Make an explicit RK group for those, though Tsit5 should be in its own because it's very popular so it should have the lowest dependency setup. |
These methods are defined together in composite_algs.jl file. What should be done for that ?? |
|
The default algorithm will need to move to an OrdinaryDiffEqDefault which depends on everything it uses in the default algorithm. |
|
The default solver needs to be its own thing. For now, just but the imports required for it before its definition. |
|
@ChrisRackauckas What changes must be made here ?? I will make those |
This reverts commit 800f61d.
|
@ChrisRackauckas I am getting a @fold error here. I saw that it's present in MacroTools. I tried to include it but it made no difference. |
|
@ChrisRackauckas Meanwhile I am done with Rosenbrock methods. |
|
@ChrisRackauckas There are some precision errors now. Due to which the tests are failing |
| alg_adaptive_order(alg::Feagin14) = 12 |
There was a problem hiding this comment.
don't reformat all of the other ones. Your formatting here is incorrect. It's already corrected on master.
|
For some reason CI didn't trigger, but that should be good to go with the last change. |
| @@ -410,7 +410,8 @@ export constructDormandPrince | |||
|
|
|||
| export FunctionMap, Euler, Heun, Ralston, Midpoint, RK4, ExplicitRK, OwrenZen3, OwrenZen4, | |||
| OwrenZen5, | |||
| BS3, BS5, DP5, Tsit5, DP8, TanYam7, TsitPap8, CompositeAlgorithm, Anas5, RKO65, FRK65, PFRK87, | |||
| BS3, BS5, DP5, Tsit5, DP8, TanYam7, TsitPap8, CompositeAlgorithm, Anas5, RKO65, | |||
| FRK65, PFRK87, | |||
There was a problem hiding this comment.
are you sure you're on the right formatter version?
There was a problem hiding this comment.
I am using this version of JuliaFormatter
[98e50ef6] JuliaFormatter v1.0.56
|
@ChrisRackauckas I started a PR for Rosenbrock Methods #2278 |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.