Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FDS-2506] Fix type Validation #1526

Merged
merged 5 commits into from
Oct 30, 2024
Merged

[FDS-2506] Fix type Validation #1526

merged 5 commits into from
Oct 30, 2024

Conversation

andrewelamb
Copy link
Contributor

@andrewelamb andrewelamb commented Oct 25, 2024 •
edited by jira bot
Loading

  • Fixes FDS-2506
  • Fixes type validation so that the msg level parameter now works as intended

BryanFauble
BryanFauble approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment, otherwise changes look good to me!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

thomasyu888
thomasyu888 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM. At some point, we want to think about auto generating validation rules documentation to capture all of this

@andrewelamb andrewelamb merged commit 59889b6 into develop Oct 30, 2024
7 checks passed
@andrewelamb andrewelamb deleted the FDS-2506-type-val branch October 30, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

@GiaJordan GiaJordan Awaiting requested review from GiaJordan

@linglp linglp Awaiting requested review from linglp

@jaymedina jaymedina Awaiting requested review from jaymedina

@BWMac BWMac Awaiting requested review from BWMac

@BryanFauble BryanFauble Awaiting requested review from BryanFauble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewelamb @thomasyu888 @BryanFauble