-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FDS-2294] Run schematic_api tests #1476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥LGTM - the code looks good, but ill leave it to FAIR team for the logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I am going to pre-approve too!
@BryanFauble I also mentioned the Jira ticket number in the PR description so that this PR is automatically links to the ticket. |
@linglp DPE adds the Jira ticket at the Github PR name |
thanks for clarifying. I just noticed that |
* add unit test of get_ca_alias * add test, remove print statement
* Adding code coverage for sonarcloud
|
Problem:
schematic_api
tests were being ignored.tangled_tree
logic that was causing test failures. It was tracked down, context was added to the comment: [FDS-2294] Run schematic_api tests #1476 (comment)Solution:
schematic_api
teststangled_tree
.Testing:
Related to this ticket: FDS-2294