Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FDS-2127] Update URL validation to use requests.options to verify connectivity #1472

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

BryanFauble
Copy link
Collaborator

@BryanFauble BryanFauble commented Aug 26, 2024

Problem:

  1. Valid URLs like https://doi.org/10.1158/0008-5472.can-23-0128 were being rejected as the urlopen was not connecting to the server hosting this webpage.

Solution:

  1. Swap to requests.options that will verify the webserver in question is reachable. Read more about the options method here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/OPTIONS

Testing:

  1. I set up a few integration tests around the changes.
  2. All tests (Except for 1) have passed: https://github.com/Sage-Bionetworks/schematic/actions/runs/10563739475/job/29264599046 - The one not passing was going to be addressed in Update test_get_manifest_with_files to match changes on synapse #1473

@BryanFauble
Copy link
Collaborator Author

This PR was moved from: #1469 into a non-forked branch

Copy link

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚄 LGTM! Thanks for doing this!

@BryanFauble BryanFauble mentioned this pull request Aug 26, 2024
Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bryan! Looks good to me.

@BryanFauble BryanFauble merged commit e3905cf into develop Aug 26, 2024
5 of 9 checks passed
@BryanFauble BryanFauble deleted the fds-2127-url-validation branch August 26, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants