add csv data model to unit tests

[lakikowolfe]

Include testing of csv data model in addition to jsonld

Related Jira ticket: https://sagebionetworks.jira.com/browse/FDS-1132

[GiaJordan]

Looking through this again, it seems like the tests in test_manifest.py and test_validation.py are still only using the .jsonld could you update to test with the CSVs where the schemas module is concerned as well?

[linglp]

@lakikowolfe can ticket be linked to PR description? Also, when I queried the logs of manifest/generate, I didn't see any projects that are using .csv url when generating a manifest.. I am curious where the "ask" comes from...

[lakikowolfe]

@linglp this is the ticket: https://sagebionetworks.jira.com/browse/FDS-1132

I believe the motivation behind this ticket is to update the tests to include csv because it is a supported file type and we'd want to know if for some reason csv input was not working.

[lakikowolfe]

@GiaJordan My understanding is that this is low priority so I am focusing on the HTAN bug ticket that I have rn and will circle back to this when I can. Please let me know if I am misunderstanding the priority of this ticket and we can discuss.

[GiaJordan]

@lakikowolfe yeah from my perspective your understanding is correct, but I'll loop in kevin so he can make the final determination

[GiaJordan]

Looking through this again, it seems like the tests in test_manifest.py and test_validation.py are still only using the .jsonld could you update to test with the CSVs where the schemas module is concerned as well?
@lakikowolfe sorry about this earlier comment, looking at the current test_schemas.py I see it's already using both the csv and jsonld. you can disregard

[GiaJordan]

Approving pending resolution of merge conflicts

[thomasyu888]

Great review @GiaJordan , and thanks for the work @lakikowolfe . Please answer some of my comments, but I'm going to go ahead and approve pending resolution of conflicts as Gianna stated

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud