-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: filenameExists
Validation Rule
#1456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f69406c
to
4c9551d
Compare
filenameExists
Validation Rule
andrewelamb
reviewed
Jul 24, 2024
andrewelamb
approved these changes
Jul 25, 2024
3cce7de
to
3451b65
Compare
|
linglp
reviewed
Jul 26, 2024
linglp
reviewed
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
filenameExists
metadata validation rule that checks for parity between the file paths in a metadata manifest (and the associated entityIds) and the file paths in the master file view on Synapse.Another associated change is that schematic's handling of paths for all files on synapse has been changed; paths now include the project name at the beginning of the path to match the format of paths in synapse file views.