Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: filenameExists Validation Rule #1456

Merged
merged 44 commits into from
Jul 29, 2024

Conversation

GiaJordan
Copy link
Contributor

@GiaJordan GiaJordan commented Jul 10, 2024

This PR introduces the filenameExists metadata validation rule that checks for parity between the file paths in a metadata manifest (and the associated entityIds) and the file paths in the master file view on Synapse.

Another associated change is that schematic's handling of paths for all files on synapse has been changed; paths now include the project name at the beginning of the path to match the format of paths in synapse file views.

@GiaJordan GiaJordan marked this pull request as draft July 10, 2024 22:22
@GiaJordan GiaJordan force-pushed the develop-filename-rule-FDS-1720 branch from f69406c to 4c9551d Compare July 22, 2024 20:59
@GiaJordan GiaJordan marked this pull request as ready for review July 22, 2024 21:02
@GiaJordan GiaJordan requested a review from andrewelamb July 23, 2024 19:22
@GiaJordan GiaJordan changed the title Develop filename rule fds 1720 Feature: filenameExists Validation Rule Jul 24, 2024
@GiaJordan GiaJordan force-pushed the develop-filename-rule-FDS-1720 branch from 3cce7de to 3451b65 Compare July 26, 2024 18:06
Copy link

@GiaJordan GiaJordan merged commit 5ca77ff into develop Jul 29, 2024
9 checks passed
@GiaJordan GiaJordan deleted the develop-filename-rule-FDS-1720 branch July 29, 2024 20:56
@GiaJordan GiaJordan restored the develop-filename-rule-FDS-1720 branch August 15, 2024 17:59
@thomasyu888 thomasyu888 deleted the develop-filename-rule-FDS-1720 branch August 31, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants