-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize validation message level determination as a precursor to single rule disjunction #1366
Conversation
@mialy-defelice resolving the conflicts was trivial; this is ready to be reviewed |
@GiaJordan I see how to the functions were refactored for simplicity, but I am having trouble following how this enables single rule disjunction? Can you explain this again? |
@mialy-defelice single rule disjunction will be enabled with #1369 |
@GiaJordan I guess my question came from this part of the description:
How do these changes allow compatibility? |
@mialy-defelice When the The logic for |
Ah gotcha, I understand now, thanks! |
@mialy-defelice no problem! |
|
Pushing up to dev, then will merge single rule disjunction directly to dev. |
This PR will help enable single rule disjunction by reworking how validation message levels are determined and the
IsNA
rule modifier introduced in #1200. The error/warning/no-message determination logic of all validation rules has been reworked to be compatible with this new rule modifier and has been simplified to be easier to maintain.Rule compatibility with the
IsNA
modifier will be finished in a subsequent PR.