Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize validation message level determination as a precursor to single rule disjunction #1366

Merged
merged 26 commits into from
Mar 21, 2024
Merged

Reorganize validation message level determination as a precursor to single rule disjunction #1366

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ac18335
reorganize validation message determination
GiaJordan Feb 8, 2024
c416dd5
update type hinting
GiaJordan Feb 8, 2024
e09ddfe
update content warning param
GiaJordan Feb 8, 2024
4b2d0cd
run black
GiaJordan Feb 8, 2024
1c3d4c4
Merge branch 'develop' into develop-val-error-handling-FDS-1352
GiaJordan Feb 9, 2024
e6c1823
run `black`
GiaJordan Feb 9, 2024
d309582
update docstring and type hint
GiaJordan Feb 9, 2024
502c804
move logic for gathering rules, rename vars
GiaJordan Feb 9, 2024
004e45d
update `IsNA` rule spec
GiaJordan Feb 9, 2024
8623119
run black
GiaJordan Feb 9, 2024
2aa21d2
update docstring
GiaJordan Feb 9, 2024
9a106e3
update type hinting
GiaJordan Feb 9, 2024
a7d4280
remove unused imports
GiaJordan Feb 9, 2024
f2cccb5
remove unused import
GiaJordan Feb 9, 2024
a4a3001
correct call for schema error
GiaJordan Feb 9, 2024
9756172
Update validate_attribute.py
GiaJordan Feb 9, 2024
ae105de
rm schema `arg_error_string`
GiaJordan Feb 9, 2024
22f9a93
use generic `list` for type hints
GiaJordan Feb 12, 2024
7687261
remove duplicated variables
GiaJordan Feb 12, 2024
83f3fb4
update docstrings
GiaJordan Feb 12, 2024
ce04cb3
update docstrings
GiaJordan Feb 12, 2024
e36ff8d
update IsNA rule spec
GiaJordan Feb 15, 2024
06c5084
revert black formatting
GiaJordan Feb 19, 2024
0cc0758
Merge branch 'develop' into develop-val-error-handling-FDS-1352
GiaJordan Feb 19, 2024
2d71b84
Merge branch 'develop' into develop-val-error-handling-FDS-1352
GiaJordan Mar 7, 2024
79aaf99
update typing
GiaJordan Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schematic/models/GE_Helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ def generate_errors(
val_rule=rule,
attribute_name=errColumn,
row_num=np_array_to_str_list(np.array(indices) + 2),
error_val=iterable_to_str_list(values),
invalid_entry=iterable_to_str_list(values),
dmge=self.dmge,
)
if vr_errors:
Expand Down
Loading
Loading