.NET 8

Directory.Build.props

@@ -7,12 +7,12 @@
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
     <IsPackable>false</IsPackable>
     <IsPublishable>false</IsPublishable>
-    <LangVersion>11.0</LangVersion>
+    <LangVersion>12.0</LangVersion>
     <Nullable>enable</Nullable>
     <OutputPath>bin\$(Platform)\$(Configuration)\</OutputPath>
     <RuntimeIdentifiers>linux-x64;win-x64;osx-arm64</RuntimeIdentifiers>
     <SatelliteResourceLanguages>none</SatelliteResourceLanguages>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <!-- Many build warnings for missing docstrings when enabling this - we may want to fix and enable per-project where needed instead? -->

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "7.0.401",
+    "version": "8.0.300",
     "rollForward": "minor"
   }
 }

news/1823-feature.md

@@ -0,0 +1 @@
+Bump to .NET 8.0 and C# 12

src/microservices/Microservices.IdentifierMapper/Messaging/BadPatientIDException.cs

@@ -6,7 +6,6 @@ namespace Microservices.IdentifierMapper.Messaging
     /// <summary>
     /// Exception thrown when the PatientID tag of a dicom file contains invalid/corrupt data
     /// </summary>
-    [Serializable]
     public class BadPatientIDException : Exception
     {
         public BadPatientIDException()
@@ -20,9 +19,5 @@ public BadPatientIDException(string message) : base(message)
         public BadPatientIDException(string message, Exception innerException) : base(message, innerException)
         {
         }
-
-        protected BadPatientIDException(SerializationInfo info, StreamingContext context) : base(info, context)
-        {
-        }
     }
 }

src/microservices/Microservices.IdentifierMapper/Messaging/IdentifierMapperQueueConsumer.cs

@@ -224,14 +224,11 @@
                 case string[] arr:
                     {
                         var unique = arr.Where(a => !string.IsNullOrWhiteSpace(a)).Distinct().ToArray();
-
-                        return unique.Length switch
-                        {
-                            0 => null,
-                            1 => unique[0],
-                            _ => throw new BadPatientIDException(
-                                $"DicomDataset had multiple values for PatientID:{string.Join("\\", arr)}")
-                        };
+                        if (unique.Length == 0)
+                            return null;
+                        if (unique.Length == 1)
+                            return unique[0];
+                        throw new BadPatientIDException($"DicomDataset had multiple values for PatientID:{string.Join("\\", arr)}");
                     }
                 default:
                     throw new BadPatientIDException($"DicomDataset had bad Type for PatientID:{val.GetType()}");