Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8 #1823

Merged
merged 3 commits into from
May 26, 2024
Merged

.NET 8 #1823

merged 3 commits into from
May 26, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented May 26, 2024

Proposed Changes

Upgrade to .NET 8 and C# 12.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.79%. Comparing base (78c7af2) to head (2183667).

Files Patch % Lines
...rMapper/Messaging/IdentifierMapperQueueConsumer.cs 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1823      +/-   ##
==========================================
- Coverage   59.82%   59.79%   -0.03%     
==========================================
  Files         177      177              
  Lines        6332     6328       -4     
  Branches      870      870              
==========================================
- Hits         3788     3784       -4     
+ Misses       2304     2303       -1     
- Partials      240      241       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm marked this pull request as ready for review May 26, 2024 09:06
@rkm rkm requested a review from a team May 26, 2024 09:07
@rkm rkm enabled auto-merge May 26, 2024 09:07
@rkm rkm merged commit f241eb5 into main May 26, 2024
19 checks passed
@jas88 jas88 deleted the net8 branch May 26, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to .NET 8
2 participants