-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sensor API #62
Added sensor API #62
Conversation
sfSensorTypeOrientation, ///< Measures the absolute 3D orientation (degrees) | ||
|
||
sfSensorTypeCount ///< Keep last -- the total number of sensor types | ||
} sfSensorType; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at how other enums are named in CSFML, and wondered if we could shorten these names somehow, either sfSensorAccelerometer
or even sfAccelerometer
.
You forgot the new |
Done, now it is more consistent with how the sfMouseButton enum is named.
Fixed, I thought kinda the opposite of @eXpl0it3r. Since I saw the brace initialization used for construction of a variable I thought I could return it directly and it wouldn't be C++11.
Could we do both events in a single new PR? I'm suggesting this because both sensor and touch APIs rely on ordering of the same enum and if stuff gets out of order the values will be wrong. |
Of course, I don't care. |
@BlaXpirit Ok, I will or if you want you can make an update and change it to |
No description provided.