Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sensor API #62

Merged
merged 1 commit into from
Feb 26, 2015
Merged

Added sensor API #62

merged 1 commit into from
Feb 26, 2015

Conversation

zsbzsb
Copy link
Member

@zsbzsb zsbzsb commented Feb 25, 2015

No description provided.

sfSensorTypeOrientation, ///< Measures the absolute 3D orientation (degrees)

sfSensorTypeCount ///< Keep last -- the total number of sensor types
} sfSensorType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at how other enums are named in CSFML, and wondered if we could shorten these names somehow, either sfSensorAccelerometer or even sfAccelerometer.

@LaurentGomila
Copy link
Member

You forgot the new SensorChanged event.

@zsbzsb
Copy link
Member Author

zsbzsb commented Feb 26, 2015

I was looking at how other enums are named in CSFML, and wondered if we could shorten these names somehow

Done, now it is more consistent with how the sfMouseButton enum is named.

This is C++11

Fixed, I thought kinda the opposite of @eXpl0it3r. Since I saw the brace initialization used for construction of a variable I thought I could return it directly and it wouldn't be C++11.

You forgot the new SensorChanged event.

Could we do both events in a single new PR? I'm suggesting this because both sensor and touch APIs rely on ordering of the same enum and if stuff gets out of order the values will be wrong.

@LaurentGomila
Copy link
Member

Could we do both events in a single new PR?

Of course, I don't care.

LaurentGomila added a commit that referenced this pull request Feb 26, 2015
@LaurentGomila LaurentGomila merged commit fb1824b into SFML:master Feb 26, 2015
@zsbzsb zsbzsb deleted the feature/sensor_api branch February 26, 2015 13:11
@zsbzsb zsbzsb mentioned this pull request Feb 26, 2015
@oprypin
Copy link
Member

oprypin commented Feb 26, 2015

SFML/SFML#806

@zsbzsb
Copy link
Member Author

zsbzsb commented Feb 26, 2015

@BlaXpirit Ok, I will or if you want you can make an update and change it to ^2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants