-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relase csfml 2.2 (or 2.1.1) ? #50
Comments
Do you really think that we were waiting for someone to open an issue, to release CSFML 2.2? 😕 There's currently nobody to maintain CSFML (and SFML.Net). Any help will be appreciated though. |
Well... yes? Seriously though, I assumed that maybe you weren't aware of this incompatibility because nobody bothered to report it.
I can't commit long-term, but if there are issues in code that need to be fixed, I'll be happy to help. |
There's no "issue" to fix currently, the latest modifications to SFML just need to be ported. |
CSFML is extremely important, because more than half of bindings to other languages depend on it (including the one I've just finished). |
The question you should be researching is: What needs to be updated before bumping the version number? |
upVector, requestFocus, sfSoundRecorder_setProcessingInterval, BlendMode, changes in fonts int->float, window focus, strikethrough are what I found by scrolling through
|
So I've published the changes in header files between [C]SFML 2.1 and 2.2 |
Very nice, thanks 😃 |
I am working on finishing the last few changes.... but I dunno what you are talking about blending modes for. CSFML (and SFML.NET) have had those changes for a while now. And my todo list... CSFML
|
If you also apply modifications pending for 2.3, we won't be able to release a clean CSFML/SFML.Net 2.2. Make all the 2.2 updates, then we release the bindings, and after that you can start working on newer modifications. |
Alright, I was just adding it there so I didn't lose track of it. |
This can be closed once #53 is merged. |
I see some unaddressed changes: Sensor, Touch, Http. |
So.... checklist is done. Verify it with @BlaXpirit's header diff. https://gist.github.com/BlaXpirit/0c9b87f1301c9cc3103d#file-sfml-diff Can we merge and then tag 2.2 now? 😈 |
Is everything ok for everyone?
Merge what? |
|
My bindings to another language work well with 2.2. Tried some new functions, no problems at all. |
Let's wait a few more days for last minute fixes. Bump me if I forget. |
At first I was going to reply with sad face, but now I realized we need at least 2 more fixes. We need to add a function for relative touch position to a render window and now SFML/SFML#806 (#67)
Will do. :) |
Everything is done, so lets plan on doing the version change merge on Sunday (March 1st)? |
📍 |
@LaurentGomila this is now a formal bump. I propose that you have forgotten about this and as your friendly neighborhood programmer I have decided to remind you. CSFML 2.2 is complete so #53 can now be merged. 😉 |
I haven't forgotten, I'm just very busy with real life problems. I should have left a word here, sorry. |
Well take your time, don't let me rush you or anything. If you have other stuff happening IRL that should take priority. |
Thank you very much! Could you please comment here when a tarball will be available on http://www.sfml-dev.org/download/csfml/ ? |
Working on builds now. Expect within a few days. 😉 |
👍 Awesome, thank you! |
Till things are collected and I've more time to update everything, feel free to test these Windows build: |
OS X is here: http://1drv.ms/1Khhx0d |
Just until @eXpl0it3r can get all this on the website. Here is CSFML 2.2 compiled with gcc on linux. |
And I don't see any dependency to a C runtime (msvcrt for VC++, or whatever for gcc), how were they compiled? The OS X release doesn't contain the documentation. Everything else looks ok 👍 |
I asked @eXpl0it3r if he was going to compile them to use static std libs. Reason being because that is how they were done in the previous releases. Also GCC was used if I am not mistaken. Also here is OS X with the docs added. |
The strange thing is that if you check the older releases, they all depend directly on MSVCRT.dll. And I think it is the right way, static standard library for DLLs that interact with each others can only end in a crash. And sorry for the 32/64 bits thing, everything's correct, my bad. |
As far as I know MSVCRT is the Microsoft Visual C Runtime and is included in the base OS. Reason being is that it is a C library and the names aren't mangled so its not specific per compiler / release. So static libs to the MSVC compiler means static C++ runtime and doesn't include the C runtime. Maybe there is a way to force it to compile statically to that runtime also, I don't know right now. Update, look what I found and here too.
|
So they were compiled with gcc and static runtime? @eXpl0it3r? I thought in this case they would be bigger, but they are even smaller than my previous builds with VC++ 😐 |
I had like no time to build stuff, so I didn't test anything. Feel free to run a test with VS and GCC. I compiled stuff with VS 2010 and link the runtime lib statically. |
I tested your builds @eXpl0it3r and they work just fine. |
With GCC as well? |
I dropped them into a SFML.NET project and to test them - didn't try linking. :/ |
@mantognini Previously there was the description "Clang - universal 32+64-bit (OS X 10.8+, compatible with C++11 and libc++)" should I keep this? |
Good catch. It should now read "Clang - universal 32+64-bit (OS X 10.7+, compatible with C++11 and libc++)". |
Yay! Thank you all! |
Thank you very much @eXpl0it3r 👏 |
Hi, csfml 2.1 is incompatible with sfml 2.2 due to changes in blending mode stuff. This commit in masetr fixes the problem: d6849a3
I'm trying to update sfml 2.1 -> sfml 2.2 so it can build on yosemite with homebrew:
Homebrew/legacy-homebrew#35279
However I'm having trouble with the csfml 2.1 <-> sfml 2.2 incompatibility.
I think it would be nice to have compatibility between latest stable csfml and sfml releases. So I suggest making a stable release of csfml(if this is possible)
The text was updated successfully, but these errors were encountered: