docs: fix type annotation for icon
slot
#6336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the JSDoc annotation of the
icon
slot for theBadge
,ComboBox
andMultiComboBox
component.For the
Badge
I changed it because the TypeScript type accepts an array ofHTMLElement
s and not only a single element. For theComboBox
and theMultiComboBox
I changed it because the type of the Input accepts an array as well and since (at least in my opinion) these components should behave in the same way, they should also accept an array.Additionally I believe that the TypeScript type of the MessageStrip is wrong. When multiple icons are rendered inside the slot it overflows the text:
![image](https://user-images.githubusercontent.com/9749730/214062807-790d088f-a8ff-4ad0-baba-51e6ec517f5e.png)
If you still want me to change the JSDoc type for the MessageStrip, please let me know.