Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 suggested changes #4460

Closed
29 tasks
ilhan007 opened this issue Dec 9, 2021 · 1 comment
Closed
29 tasks

2.0 suggested changes #4460

ilhan007 opened this issue Dec 9, 2021 · 1 comment

Comments

@ilhan007
Copy link
Member

ilhan007 commented Dec 9, 2021

Background

This issue lists all deprecated APIs and all APIs that we would like to improve and change before releasing next major version (2.0).

Deprecated modules

  • Assets-static.js in several packages should be removed

Changes agreed:

  • ❗ [breaking] ❗ Remove Assets-static.js from all packages

@ui5/webcomponents-base

Changes under discussion:

  • Remove fallback to default value
  • check and rework defaultValues of property types, input.value doesn't have default and it accepts null/undefined
  • properties of type Object have {} by default, probably undefined will be a better default.
  • Check "allowList" array and remove/rename properties if needed
  • Revise all the events that have stopped bubbling.

Changes agreed:

  • ❗ [breaking] ❗ CSP Support will be supported out of the box via the adopted stylesheets that are now supported everywhere.

UI5Element

Changes agreed:

  • [enhancement] Enable dynamic load of dependencies
  • ❗ [breaking] ❗ Remove static get render (to be replaced by renderer)
  • ❗ [breaking] ❗ Remove getStaticAreaItemDomRef as obsolete

UI5ElementMetadata

Changes under discussion:

  • Remove processChildren

Changes agreed:

  • [enhancement] manageSlot to become per slot

Device

Changes agreed:

  • ❗ [breaking] ❗ Remove the Device#isIE() method

Static Areа

Changes agreed:

  • ❗ [breaking] ❗ Remove Static Area and Static Area items

Form Support

Changes agreed:

@ui5/webcomponents-tools

Changes agreed:

  • ❗ [breaking] ❗ Remove the support of JS development from our tools , although the framework will still allow creating components with pure JS.
  • ❗ [breaking] ❗ Remove the JSDoc plugin
  • ❗ [breaking] ❗ Upgrade to new major wdio version would breaking for consumers of wdio.config.js - check if needed as there is research to use Cypress in future

@ui5/webcomponents-theming

Changes agreed:

  • ❗ [breaking] ❗ Remove Belize theme

@ui5/webcomponents, @ui5/webcomponents-fiori

Move components

Changes agreed:

  • ❗ [breaking] ❗ - move the Bar component from fiori to main package.

Grouping implementation

Props

Changes under discussion:

  • Remove TabContainer's deprecated property showOverflow
  • Review AriaHasPopup enum values. Which values are still relevant and shouldn't they be lowercase?

Changes agreed:

  • Keep IllustratedMessage#title slot
  • Keep IllustratedMessage#subtitle slot
  • ❗ [breaking] ❗ Remove Option#disabled - remove as UX and ACC standards suggest to not include any disabled items in the dropdown
  • ❗ [breaking] ❗ Remove ProgressIndicator#disabled- a disabled indicator can be part of disabled UI (Form, Panel), but does not make sense on its own. Also aria-disabled state is deprecated for the component, and it's not requested by a client.
  • ❗ [breaking] ❗ Rename SegmentedButtonItem#pressed to "selected"
  • ❗ [breaking] ❗mode properties in Table, List, SegmentedButton to become selectionMode
  • ❗ [breaking] ❗Change Calendar's event selected-dates-change to selection-change
  • ❗ [breaking] ❗ Change the Calendar's event details values and dates to selectedValues and selectedDateValues.
  • ❗ [breaking] ❗Change some enum values in TableMode, ListMode, SegmentedButtonMode: SingleSelect -> Single, MultiSelect -> Multiple
  • ❗ [breaking] ❗ Change Enums' names: TableMode -> TableSelectionMode, ListMode -> ListSelectionMode, SegmentedButtonMode -> SegmentedButtonSelectionMode

Events

Changes under discussion:

  • Check the presence of the following events: open-change, open, close, before-open, before-close, after-open, after-close.

Event Details

Changes under discussion:

  • Check targetRef and ref presence and stick to the one or to the other.

Slots

Changes under discussion:

  • Check icon slot presence and rename to "icons"

Methods

Changes under discussion:

  • Check openPicker, togglePicker or similar methods and unify them

Enums

Changes agreed:

  • ❗ [breaking] ❗ Rename PopoverHorizontalAlign values - Left, Right --> Start, End
  • ❗ [breaking] ❗ Rename PopoverPlacementType - Left, Right --> Start, End

Interfaces

  • - Revise existing interfaces, because many of them are implemented by only 1 component and seems redundant for the moment. Also many of the interfaces contain only 1 private property which name start with underscore and doesn't have jsdoc comment to describe it, for example:
interface TestInterface {
    _test: string;
}

Let's discuss how to proceed with these interfaces.

@ui5/webcomponents-icons

Changes agreed:

  • ❗ [breaking] ❗ - Remove "soccor", keep "soccer"

@ui5/webcomponents-icons-business-suite

Changes agreed:

  • ❗ [breaking] ❗ - Remove "add-polygone", keep "add-polygon"
@ilhan007 ilhan007 pinned this issue Dec 9, 2021
@ilhan007 ilhan007 changed the title [TOPIC] Deprecated APIs [TOPIC] Deprecated APIs before major release Jan 11, 2022
@ilhan007 ilhan007 changed the title [TOPIC] Deprecated APIs before major release [TOPIC] 2.0 topics Dec 13, 2022
@ilhan007 ilhan007 changed the title [TOPIC] 2.0 topics [TOPIC] TODO list before - 2.0 Dec 14, 2022
@ilhan007 ilhan007 changed the title [TOPIC] TODO list before - 2.0 [TOPIC] 2.0 breaking changes list Feb 20, 2023
@nnaydenow nnaydenow unpinned this issue May 31, 2023
@ilhan007 ilhan007 pinned this issue May 31, 2023
@ilhan007 ilhan007 added this to the 1.23.0 milestone Dec 18, 2023
@ilhan007 ilhan007 added the 2.0 label Jan 26, 2024
@SAP SAP deleted a comment from hristop Feb 28, 2024
@ilhan007
Copy link
Member Author

ilhan007 commented Jul 3, 2024

Suggested Changes have been reviewed in the past months and refined to new list of Planned changes:
#8461

@ilhan007 ilhan007 closed this as completed Jul 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic RL Jul 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic P Jul 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Planning - Topic RD Jul 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic B Jul 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic Core Jul 3, 2024
@ilhan007 ilhan007 unpinned this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Status: Completed
Status: Completed
Status: Completed
Status: Q1 2024
Development

No branches or pull requests

1 participant