Adds document attribute for disable tcpcheck #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardl
requested changes
Nov 4, 2024
client/luigi-client.d.ts
Outdated
| export function addInitListener(initFn: (context: Context, origin?: string) => void, disableTpcCheck?: boolean): number; | ||
| export type addInitListener = ( | ||
| initFn: (context: Context, origin?: string) => void, | ||
| disableTpcCheck?: boolean |
There was a problem hiding this comment.
please keep the disableTcpCheck argument, it should still be possible to disable via js, e.g. in a test environment.
client/src/lifecycleManager.js
Outdated
| * @memberof Lifecycle | ||
| * @example | ||
| * const initListenerId = LuigiClient.addInitListener((context) => storeContextToMF(context)) | ||
| */ | ||
| addInitListener(initFn, disableTpcCheck) { | ||
| this.disableTpcCheck = disableTpcCheck; | ||
| addInitListener(initFn) { |
There was a problem hiding this comment.
please keep the disableTcpCheck argument, it should still be possible to disable via js, e.g. in a test environment.
if it is true, just call document.head.setAttribute('disable-tpc-check') here instead of this.disableTpcCheck=true
client/src/luigi-client.js
Outdated
| @@ -26,8 +26,8 @@ class LuigiClient { | |||
| } | |||
| } | |||
|
|
|||
| addInitListener(initFn, disableTpcCheck) { | |||
| return lifecycleManager.addInitListener(initFn, disableTpcCheck); | |||
| addInitListener(initFn) { | |||
hardl
approved these changes
Nov 4, 2024
client/src/lifecycleManager.js
Outdated
| @@ -140,17 +148,21 @@ class LifecycleManager extends LuigiClientBase { | |||
| } | |||
|
|
|||
| _tpcCheck() { | |||
| if (this.currentContext?.internal?.thirdPartyCookieCheck?.disabled || this.disableTpcCheck) { | |||
| const tpcCheckDisabled = | |||
| this._isTpcCheckDisabled() || this.currentContext?.internal?.thirdPartyCookieCheck?.disabled; | |||
There was a problem hiding this comment.
moving the check
this.currentContext?.internal?.thirdPartyCookieCheck?.disabled;
into _isTpcCheckDisabled() could save one LOC ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
disableTpcCheckprop to keep one source of truthRelated issue(s)
Resolves #4006