Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client: use document.head attribute as single-source-of-truth for disable tcpCheck #4006

Closed
hardl opened this issue Oct 31, 2024 · 0 comments · Fixed by #4008
Closed

Client: use document.head attribute as single-source-of-truth for disable tcpCheck #4006

hardl opened this issue Oct 31, 2024 · 0 comments · Fixed by #4008
Assignees
@walmazacn
Labels
enhancement New feature or request

Comments

@hardl
Copy link
Contributor

hardl commented Oct 31, 2024

instead of setting the member variable this.disableTpcCheck here https://github.com/SAP/luigi/blob/ed8eae559b78c46d8c59c3ff8a6ccd207c2d411d/client/src/lifecycleManager.js#L234C10-L234C26, set an attribute at document.head and read its value here

luigi/client/src/lifecycleManager.js

Line 143 in ed8eae5

if (this.currentContext?.internal?.thirdPartyCookieCheck?.disabled || this.disableTpcCheck) {

This allows disabling tcpCheck not only via luigi client but also declarative in mfe html.
@walmazacn walmazacn self-assigned this Oct 31, 2024
@walmazacn walmazacn linked a pull request Oct 31, 2024 that will close this issue
Adds document attribute for disable tcpcheck #4008
Merged
@walmazacn walmazacn mentioned this issue Oct 31, 2024
Merged
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walmazacn walmazacn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds document attribute for disable tcpcheck SAP/luigi
3 participants
@hardl @JohannesDoberer @walmazacn