Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tmsUpload, tmsExport] Provide additional log message on successful upload and export to node #4624
[tmsUpload, tmsExport] Provide additional log message on successful upload and export to node #4624
Changes from 3 commits
f7a0f9f
03fdbde
4f35e2c
4fc3adf
f51a1af
ca7ffc7
6033f73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we cannot offer them something else, such as variables in the common pipeline environment (CPE)? Maybe additionally to the log message we could also provide the information in CPE variables. Then they can use that in the pipeline, without having to parse the log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that will be an ideal case. For now, we have agreed with the Customer, who complained about missing log message after we switched to the new Golang implementation of the step, that we provide a log message with transport request id in the Golang implementation as well.
Usage of variables in CPE or other options, if they are, have to be and will be discussed separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's do so. @marcusholl What do you think? Would it help Piper users, if they could retrieve this information from the CPE, rather than parsing the log? Is there something else we could offer, apart from the CPE?