[tmsUpload, tmsExport] Provide additional log message on successful upload and export to node #4624
Conversation
| } | ||
| communicationInstance.logger.Info("Node upload executed successfully") | ||
|
|
||
| // Important: there are Customers, who might rely on format of this log message to parse transport request id |
There was a problem hiding this comment.
And we cannot offer them something else, such as variables in the common pipeline environment (CPE)? Maybe additionally to the log message we could also provide the information in CPE variables. Then they can use that in the pipeline, without having to parse the log.
There was a problem hiding this comment.
And we cannot offer them something else, such as variables in the common pipeline environment (CPE)?
Yes, that will be an ideal case. For now, we have agreed with the Customer, who complained about missing log message after we switched to the new Golang implementation of the step, that we provide a log message with transport request id in the Golang implementation as well.
Usage of variables in CPE or other options, if they are, have to be and will be discussed separately.
There was a problem hiding this comment.
Ok, let's do so. @marcusholl What do you think? Would it help Piper users, if they could retrieve this information from the CPE, rather than parsing the log? Is there something else we could offer, apart from the CPE?
@o-liver I didn't get you here. |
Only that this fileInfo object is new to me. Although it has already been in the code from the get go. Just wanted to confirm that this is tested with the ITs. So there is a test that deserializes the response json into this object. |
|
@o-liver Could you please trigger all the relevant pipelines, so they could check, if I haven't forgotten to change anything. |
|
/it |
|
FYI @kaylinche @alxsap |
https://github.com/artembannikov/jenkins-library into artembannikov/tmsUpload_print_additional_log_messages
|
@o-liver Please trigger the pipelines again. I have provided fixes for failing unit tests. |
|
/it |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/it |
…pload and export to node (#4624) * Provide additional log message on successful upload and export to node --------- Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
…pload and export to node (SAP#4624) * Provide additional log message on successful upload and export to node --------- Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Changes