Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No space password with regex #166

Merged
merged 7 commits into from
May 25, 2023
Merged

No space password with regex #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3098a6d
added custom validation rule using regex to not allow users to use sp…
MikeProduce May 21, 2023
bd245bb
added validation rule that ensures password field does not contain on…
MikeProduce May 21, 2023
231c5c5
Revert "added validation rule that ensures password field does not co…
MikeProduce May 21, 2023
dc18850
added a better regex that is more versitle and a descriptive error th…
MikeProduce May 21, 2023
c3a61c6
registerManager.ts @matches did not match the correct string from sig…
MikeProduce May 22, 2023
5b0dda9
updated both t() functions(matches and max) so that they match the c…
MikeProduce May 22, 2023
76b4c05
Update password validation message
Ryczko May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion locales/en/signup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@
"alreadyHaveAccount": "Already have an account?",
"authError": "Authentication failed",
"accountWithEmailAlreadyExist": "The account already exists for that email.",
"registerError": "Registration failed!"
"registerError": "Registration failed!",
"restrictedCharacterError": "Password contains illegal characters."
}
4 changes: 4 additions & 0 deletions src/features/authorization/managers/registerManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ export const useRegisterManager = () => {
.email(t('signup:incorrectEmail'))
.required(t('signup:required')),
password: Yup.string()
.matches(
/^[a-zA-Z0-9!@#$%^&*()_+-]+$/,
t('signup:restrictedCharacterError')
)
.min(8, t('signup:passwordLengthMin'))
.max(64, t('signup:passwordLengthMax'))
.required(t('signup:required')),
Expand Down