Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No space password with regex #166

Merged
merged 7 commits into from
May 25, 2023
Merged

Conversation

MikeProduce
Copy link
Contributor

Added regex to know if the user has any spaces in their password.If they do they will be met with the validation message from the signup.json file "password cannot contain spaces"

Let me know if I need to make any further changes.
feedback is always appreciated thank you !

…aces in passwords and also updated the signup.json file that contains the validation message.
@vercel
Copy link

vercel bot commented May 21, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Ryczko on Vercel.

@Ryczko first needs to authorize it.

@MikeProduce
Copy link
Contributor Author

Also note, Ignore package.lock.json files those were not meant to be committed

@Ryczko
Copy link
Owner

Ryczko commented May 21, 2023

Hello maybe one suggestion :)
Better approach is to force using only specific sets of characters. Let's use regex like this /^[a-zA-Z0-9!@#$%^&*()_+-]+$/, and as error message something similar to "Password contains illegal characters".

@MikeProduce
Copy link
Contributor Author

Okay will make that change ! 👍

…at tells the user what characters are available for use
@MikeProduce
Copy link
Contributor Author

@Ryczko I made a another pull request. I wanted your opinion on the message. I personally feel like its a little long but i also wanted to let the user know what exactly they can use. Let me know if I should go with the current message or try something a little bit more shorter. thanks!

…nup.json.Changed it so it matches restrictedCharacterError
@MikeProduce
Copy link
Contributor Author

changes were made so that the signup.json file matches the strings inside the t() function to show validation messages.

also @Ryczko sorry for all the commits. I apologize, let me know if you want me to make any further changes
thank you for your time

@Ryczko
Copy link
Owner

Ryczko commented May 25, 2023

@MikeProduce I made it a little bit shorter. Thank for the contribution 👏

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formslab ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 6:13pm

@Ryczko Ryczko linked an issue May 25, 2023 that may be closed by this pull request
@Ryczko Ryczko temporarily deployed to preview May 25, 2023 18:14 — with GitHub Actions Inactive
@Ryczko Ryczko merged commit 95de4ad into Ryczko:dev May 25, 2023
@MikeProduce
Copy link
Contributor Author

No problem bro thank you for letting me participate and giving me feedback much appreciated! 👍

@MikeProduce MikeProduce deleted the no-space-password branch August 9, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password field accepts only spaces as a password
2 participants