Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] “All Categories” dropdown menu shaking #27385

Closed
wants to merge 7 commits into from

Conversation

felipe-rod123
Copy link
Contributor

@felipe-rod123 felipe-rod123 commented Nov 28, 2022

Proposed changes (including videos or screenshots)

  • “All Categories” dropdown menu is shaking when opened.
  • To solve this, I created a custom style inside another <div> in the apps/meteor/client/views/admin/apps/components/DropDownListWrapper.tsx component file.
  • I also created a custom hook to check for screen width changes, and apply the correct style.

Update-Dropdown

Issue(s)

Steps to test or reproduce

  1. Go to the workspace admin panel
  2. Click on the “apps” menu
  3. Click on the filter “All Categories”.

Old-Dropdown

Further comments

Other suggestions to fix this error without CSS are welcome!

MKP-99

@felipe-rod123 felipe-rod123 requested review from rique223 and a team November 28, 2022 18:35
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #27385 (f24ed4b) into develop (77630df) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27385      +/-   ##
===========================================
- Coverage    43.06%   43.05%   -0.02%     
===========================================
  Files          815      815              
  Lines        17090    17090              
  Branches      1938     1938              
===========================================
- Hits          7360     7358       -2     
- Misses        9464     9466       +2     
  Partials       266      266              
Flag Coverage Δ
e2e 43.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@felipe-rod123 felipe-rod123 marked this pull request as ready for review November 28, 2022 23:44
@felipe-rod123 felipe-rod123 requested a review from a team as a code owner November 28, 2022 23:44
rique223
rique223 previously approved these changes Nov 29, 2022
@rique223 rique223 requested a review from dougfabris November 29, 2022 17:06
@dougfabris
Copy link
Member

@felipe-rod123 Closing this one as the core of the problem was solved here #967

@dougfabris dougfabris closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants