Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoticons broken with a question mark at the end #967

Closed
ninja- opened this issue Oct 2, 2015 · 2 comments
Closed

Emoticons broken with a question mark at the end #967

ninja- opened this issue Oct 2, 2015 · 2 comments

Comments

@ninja-
Copy link

ninja- commented Oct 2, 2015

Testcase:

  1. type ":D?"
  2. expected is a rendered emoticon
  3. there is no emoticon rendered unlike ":D" and ":D!"
@s4kh
Copy link

s4kh commented Oct 14, 2015

I fixed this on the emojione.js of forked rep and passed pull request, when will Rocket.Chat js will be updated?

@gmsecrieru
Copy link
Contributor

Based on this comment it looks like this is an expected behavior and your PR will not be merged.

Closing as this is not an issue with RocketChat itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants