Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Emoji not working with questionmark in the end #137

Closed
fabianschwarzfritz opened this issue Oct 10, 2015 · 4 comments
Closed

Emoji not working with questionmark in the end #137

fabianschwarzfritz opened this issue Oct 10, 2015 · 4 comments

Comments

@fabianschwarzfritz
Copy link

Hola,

On In Rocket.Chat, there is an issue describing RocketChat/Rocket.Chat#967 a string that does not convert to an emoji.

However, this is not a RocketChat, problem, but a functionality that is not working with emojione. I thinks it's better to track that issue here.

Cheers,
Fabian

@mikebe11
Copy link
Contributor

Hi Fabian,
This isn't an Emoji One problem. Our library is functioning with the ascii conversion. ":D?" is not in our ascii list. We don't have ":D!" either. If you want to support that ascii smiley in RocketChat you'd have to include it in your program's list of supported ascii combinations.

@s4kh
Copy link

s4kh commented Oct 14, 2015

Hi Mike,

In emojione shortnameToImage function regex replace is not working for :D? but working for ":D!"

@mikebe11
Copy link
Contributor

@s4kh I got it now. Was looking at the ? as a component of the ascii smiley and not as sentence punctuation.

@mikebe11
Copy link
Contributor

Should be good here. #135 added the ?
Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants