Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Videos stuttering when Spoof Client Patch is enabled. #3353

Closed
3 tasks done
YouSummoner opened this issue Jun 17, 2024 · 17 comments
Closed
3 tasks done

bug: Videos stuttering when Spoof Client Patch is enabled. #3353

YouSummoner opened this issue Jun 17, 2024 · 17 comments
Labels
Bug report Something isn't working

Comments

@YouSummoner
Copy link

Bug description

  1. Go to Revanced miscellaneous settings.
  2. Enable the Client Spoof Patch.
  3. Restart app and try to play a video.
5_6307549732084387332.mp4

Logs:
logcat.log
event.log

Error logs

.

Solution

This doesn't happen if the patch is disabled, but then the buffering problem persists, which this patch was made to solve.

Additional context

This stuttering doesn't happen on every video, maybe due to the uploaded video's codec.
Some of the youtube channels I've faced this issue are known as (Tech Karan) and (Everything Android).

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@YouSummoner YouSummoner added the Bug report Something isn't working label Jun 17, 2024
@oSumAtrIX
Copy link
Member

Compare the codec used in the unpatched app and the patched app via the nerd menu in YouTube

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Jun 17, 2024
@LisoUseInAIKyrios
Copy link
Contributor

Try turning off iOS spoofing (which then uses Android VR spoofing).

Also verify Spoof device dimensions is not enabled.

@YouSummoner
Copy link
Author

Compare the codec used in the unpatched app and the patched app via the nerd menu in YouTube

Sure, here's the stats from original youtube app:
Screenshot_20240618-020058_Precise Frame mpv Video Player
And the patched app:
Screenshot_20240618-021227_Precise Frame mpv Video Player

@YouSummoner
Copy link
Author

YouSummoner commented Jun 17, 2024

Try turning off iOS spoofing (which then uses Android VR spoofing).

Also verify Spoof device dimensions is not enabled.

Device dimensions patch is not enabled...
And yes, this issue doesn't happen with the Android VR spoof, just the iOS one...

@oSumAtrIX
Copy link
Member

@oSumAtrIX
Copy link
Member

Moved to #3208

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@LisoUseInAIKyrios
Copy link
Contributor

@YouSummoner which phone was this reproduced on?

@YouSummoner
Copy link
Author

YouSummoner commented Jun 18, 2024 via email

@LisoUseInAIKyrios
Copy link
Contributor

From what I can gather, that has a Snapdragon 712 and has hardware AVC1 support but not AV1.

I just noticed your logs show you are using a fork of ReVanced.

Check again using the latest official ReVanced, with iOS spoofing, the same video, and report back which codec is used.

@YouSummoner
Copy link
Author

From what I can gather, that has a Snapdragon 712 and has hardware AVC1 support but not AV1.

I just noticed your logs show you are using a fork of ReVanced.

Check again using the latest official ReVanced, with iOS spoofing, the same video, and report back which codec is used.

Alright, I patched the app myself using the official patches(only selected the patches for ADs, spoof client and GmsCore while patching), but it's still stuttering with the spoof iOS patch enabled... here's the stats...
Screenshot_20240618-070823_YouTube

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Jun 18, 2024

It's correctly using vp9 (since the device av1 check did not pass), but it's still stuttering. Lots of dropped frames showing in the stats.

So the issue is not the codec, but something else with the iOS spoof.

@oSumAtrIX
Copy link
Member

The unpatched app uses avc1 whereas the patched app uses vp9, probably that's why.

@LisoUseInAIKyrios
Copy link
Contributor

@YouSummoner what codec is used with Android VR spoof?

@YouSummoner
Copy link
Author

@YouSummoner what codec is used with Android VR spoof?

Stats with Android VR spoof:
Screenshot_20240618-075809_YouTube

@oSumAtrIX
Copy link
Member

You previously claimed:

And yes, this issue doesn't happen with the Android VR spoof

In your latest picture it shows dropped frames though. So what now?

@YouSummoner
Copy link
Author

I can't say about the stats, but I can confirm that no stuttering was visible to the eye while playback of the video. Though I did check again on the same video with Android VR spoof and here's the stats from that, this time it isn't showing any dropped frames.
Screenshot_20240618-095654_YouTube

@GKid94

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants