feat(YouTube - Spoof client): Allow forcing AVC codec with iOS

[LisoUseInAIKyrios]

Integration changes for ReVanced/revanced-patches#3570

[LisoUseInAIKyrios]

it might be worth adding a toggle for iOS to force AVC1, as it appears some devices can act up when using VP9 (even though they have VP9 hardware decoding)

ReVanced/revanced-patches#3353

edit: the issue above might be unrelated and have nothing to do with AVC1 vs VP9

[oSumAtrIX]

Why would the issue be unrelated?

[LisoUseInAIKyrios]

Because the user in that issue also saw dropped frames in Android VR as well.

[LisoUseInAIKyrios]

It might be worth renaming revanced_spoof_client_use_ios to something else, as this setting was originally default off, then it was removed, then it came back as default on.

So some users updating from the first release of Spoof client will have Android VR turned on by default, caused by their old settings.

The downside to this change is anyone who currently has and wants Android VR will have to change the setting again.

[LisoUseInAIKyrios]

Added AVC1 (aka H.264) override.

Googling for "VP9 problems" and you get many forum and bug reports for non YouTube apps that struggle with VP9 (and report no problem with AVC1), despite the reported devices officially supporting VP9. So perhaps the devices don't support VP9 in all codec configurations, or the device overheats with VP9 and throttles the chipset.

The users who report VP9 issues seem to be those with older first generation VP9 chipsets (such as Snapdragon 810 released in 2015), or they have a budget non mainstream chipset.

[kitadai31]

After some sleep, I finally came up with a logic to check both codecs in one check. 😅
Please give me a chance to suggest this code.

/**
 * @return 0 = AVC, 1 = VP9, 2 = AV1
 */
private static int checkSupportedHardwareDecoding() {
    boolean vp9found = false;
    MediaCodecList codecList = new MediaCodecList(MediaCodecList.ALL_CODECS);

    for (MediaCodecInfo codecInfo : codecList.getCodecInfos()) {
        final boolean isHardwareAccelerated = (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q)
                ? codecInfo.isHardwareAccelerated()
                : !codecInfo.getName().startsWith("OMX.google"); // Software decoder.
        if (isHardwareAccelerated && !codecInfo.isEncoder()) {
            for (String type : codecInfo.getSupportedTypes()) {
                if (type.equalsIgnoreCase("video/av01")) {
                    Logger.printDebug(() -> "Device supports AV1 hardware decoding.");
                    return 2;
                } else if (!vp9found && type.equalsIgnoreCase("video/x-vnd.on2.vp9")) {
                    vp9found = true;
                }
            }
        }
    }

    if (vp9found) {
        Logger.printDebug(() -> "Device supports VP9 hardware decoding.");
        return 1;
    } else {
        Logger.printDebug(() -> "Device does not support either VP9 or AV1 hardware decoding.");
        return 0;
    }
}

/**
 * Represents the hardware decoding supported by the device.
 * 0 = AVC only.
 * 1 = VP9 hardware decoding is supported.
 * 2 = AV1 hardware decoding is supported.
 */
private static final int SUPPORTED_CODEC_LEVEL = checkSupportedHardwareDecoding();
private static boolean allowVP9() {
    return SUPPORTED_CODEC_LEVEL >= 1 && !Settings.SPOOF_CLIENT_IOS_FORCE_AVC1.get();
}
private static boolean allowAV1() {
    return SUPPORTED_CODEC_LEVEL >= 2;
}

I have no idea if this code is well designed or not.

[LisoUseInAIKyrios]

That works. But for this situation I think a little copy paste and using two methods is simpler and easier to understand.