-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube): Can't back out of 'Get YouTube Premium' with back swipe or back button #3071
Comments
@ILoveOpenSourceApplications does this still happen if patched with only The back button behavior is changed by Does this menu appear in the litho logs? |
Yes.
If patched with
I haven't tested that. I'll check and follow-up. |
Litho logs after opening 'Get YouTube Premium'
04-23 14:35:54.378 15540 15720 D revanced: LithoFilterPatch: Searching ID: lp_empty_section.eml|96f658dcd6c06283 Path: lp_empty_section.eml|96f658dcd6c06283|CellType| BufferStrings: 1713863154027174935Γ¥Ölp_empty_section.eml|96f658dcd6c06283Γ¥Ö
04-23 14:35:54.382 15540 15720 D revanced: LithoFilterPatch: Searching ID: lp_section_group.eml-js-b|3614f991928f1cbc Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType| BufferStrings: lp_small_feature_group.eml|57624041f4e9a4e0Γ¥Ö1713863154027174939Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15720 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType| BufferStrings: lp_small_feature_group.eml|57624041f4e9a4e0Γ¥Ö1713863154027174939Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15721 D revanced: LithoFilterPatch: Searching ID: lp_section_group.eml-js-b|3614f991928f1cbc Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType| BufferStrings: *`YuΓ¥Ölp2_header.eml|dd9109c15e578561Γ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_5760x9600.jpgΓ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_2880x4800.jpgΓ¥Ö1713863154027174938Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15721 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType|ContainerType| BufferStrings: *`YuΓ¥Ölp2_header.eml|dd9109c15e578561Γ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_5760x9600.jpgΓ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_2880x4800.jpgΓ¥Ö1713863154027174938Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15721 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType|ContainerType|ImageType| BufferStrings: *`YuΓ¥Ölp2_header.eml|dd9109c15e578561Γ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_5760x9600.jpgΓ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_2880x4800.jpgΓ¥Ö1713863154027174938Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.382 15540 15721 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType|ContainerType| BufferStrings: *`YuΓ¥Ölp2_header.eml|dd9109c15e578561Γ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_5760x9600.jpgΓ¥Öhttps://www.gstatic.com/youtube/img/promos/growth/premium_lp2_header_background_dark_phone_portrait_v1_2880x4800.jpgΓ¥Ö1713863154027174938Γ¥Ölp_section_group.eml-js-b|3614f991928f1cbcΓ¥Ö
04-23 14:35:54.383 15540 15720 D revanced: LithoFilterPatch: Searching ID: null Path: lp_section_group.eml-js-b|3614f991928f1cbc|CellType|lp_small_feature_group.eml|57624041f4e9a4e0|ContainerType| BufferStrings: lp_small_feature.eml|2e0b518e5db21b2Γ¥Ölp_small_feature.eml|2e0b518e5db21b2Γ¥Ölp_small_feature.eml|2e0b518e5db21b2Γ¥Ölp_small_feature.eml|2e0b518e5db21b2Γ¥ÖEX'kΓ¥Ö |
What about the menu entry in the settings (the setting option that opens the problematic menu), is it in the litho logs? |
oddly, this has started working correctly for me. Now the using the hardware back button or tapping the back icon correctly closes the prompt. |
No improvement on my end. |
I am not able to reproduce the issue. Please check the same version of the unpatched app for this issue. |
There's no issue in the unpatched app. ReVanced YouTube v19.11.43 has the issue though on the other side. |
If only GmsCore support patch was used I doubt ReVanced has anything to do with the issue. Switch accounts and reset app data to test for A/B. |
It could be an A/B testing. I downgraded back to v19.09.37 with GmsCore only, no issue. Upgraded to v19.10.39 GmsCore only, still no issue. Upgraded again back to 19.11.43 GmsCore only and still no issue. Patched again with patches that I use, and still no issue. So that sums it up. |
And now the issue is back :) |
I also noticed that, if the issue exists then when the user open the option the buffer icons refreshes twice before opening the setting. And it doesn't then there's no issue. A strange issue indeed. |
# [2.193.0-dev.7](ReVanced/revanced-patches@v2.193.0-dev.6...v2.193.0-dev.7) (2023-10-08) ### Features * **YouTube:** Bump compatibility to `18.38.44` ([ReVanced#3071](ReVanced/revanced-patches#3071)) ([a73868c](ReVanced/revanced-patches@a73868c))
# [2.193.0](ReVanced/revanced-patches@v2.192.0...v2.193.0) (2023-10-08) ### Bug Fixes * **Boost for Reddit - Spoof client:** Set user-agent for OAuth requests to fix login ([2223951](ReVanced/revanced-patches@2223951)) * Consolidate patches ([ReVanced#3098](ReVanced/revanced-patches#3098)) ([02f767d](ReVanced/revanced-patches@02f767d)) * **Infinity for Reddit - Spoof client:** Set user-agent for OAuth requests to fix login ([a710f05](ReVanced/revanced-patches@a710f05)) * **Sync for Reddit - Spoof client:** Set user-agent for OAuth requests to fix login ([a48c4a7](ReVanced/revanced-patches@a48c4a7)) * **YouTube:** Sort settings alphabetically despite punctuation ([ReVanced#3097](ReVanced/revanced-patches#3097)) ([46e3c97](ReVanced/revanced-patches@46e3c97)) ### Features * **YouTube - Hide shorts components:** Hide subscribe button when paused separately from subscribe button ([52d07ec](ReVanced/revanced-patches@52d07ec)) * **YouTube - Return YouTube Dislike:** Support version `18.37.36` ([ReVanced#3061](ReVanced/revanced-patches#3061)) ([fe11db7](ReVanced/revanced-patches@fe11db7)) * **YouTube:** Add `Disable fine scrubbing gesture` patch ([6c9baf2](ReVanced/revanced-patches@6c9baf2)) * **YouTube:** Bump compatibility to `18.38.44` ([ReVanced#3071](ReVanced/revanced-patches#3071)) ([a73868c](ReVanced/revanced-patches@a73868c))
Bug description
If the user goes into 'Get YouTube Premium' option in library and tries to back out by using the gesture control or by tapping the back arrow, the screen keeps looping back into it.

Screen_Recording_20240423_013752_YouTube.mp4
Error logs
No response
Solution
No response
Additional context
Spamming the back swipe/back button does seem to work but that's not the ideal solution.
Acknowledgements
The text was updated successfully, but these errors were encountered: