-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube - Settings): Copy-paste menu has a background layer #3061
Comments
In this image, copy-paste menu is white for some reason. Is it a bug due to the theme patch? I believe this mainly due to #2786. |
Fixing this is tricky, because Android preferences are trash and horribly inflexible and finicky. When I first wrote this custom preference I tried different ways to fix this copy/paste layout sizing but couldn't come up with any fix. But selecting text individually is not a common use case, and there is a 'copy' button at the bottom. A more useful change, is to prevent the keyboard from showing when the import/export is opened. Because the user does not type text into this box, but instead copy/pastes everything (so typically the user never selects any text). |
After searching around, I came across this question and an answer at the very bottom which isn't verified, but is it of any help? |
Many of these solutions cannot be easily applied programmatically, since the style is a compiled xml file and integrations cannot access any of these files from the Patches project. Maybe changing the style xml file for YT itself would work, but that might be a bad idea and cause other strange issues. I revisited trying different ways to force the keyboard not to show, but still could not prevent the keyboard from showing. |
@LisoUseInAIKyrios, does this comment from @inotia00 help? He's also provided the commits in this comment. |
Yes that works, and could be used to fix this. |
# [2.193.0-dev.3](ReVanced/revanced-patches@v2.193.0-dev.2...v2.193.0-dev.3) (2023-10-07) ### Features * **YouTube - Return YouTube Dislike:** Support version `18.37.36` ([ReVanced#3061](ReVanced/revanced-patches#3061)) ([fe11db7](ReVanced/revanced-patches@fe11db7))
# [2.193.0](ReVanced/revanced-patches@v2.192.0...v2.193.0) (2023-10-08) ### Bug Fixes * **Boost for Reddit - Spoof client:** Set user-agent for OAuth requests to fix login ([2223951](ReVanced/revanced-patches@2223951)) * Consolidate patches ([ReVanced#3098](ReVanced/revanced-patches#3098)) ([02f767d](ReVanced/revanced-patches@02f767d)) * **Infinity for Reddit - Spoof client:** Set user-agent for OAuth requests to fix login ([a710f05](ReVanced/revanced-patches@a710f05)) * **Sync for Reddit - Spoof client:** Set user-agent for OAuth requests to fix login ([a48c4a7](ReVanced/revanced-patches@a48c4a7)) * **YouTube:** Sort settings alphabetically despite punctuation ([ReVanced#3097](ReVanced/revanced-patches#3097)) ([46e3c97](ReVanced/revanced-patches@46e3c97)) ### Features * **YouTube - Hide shorts components:** Hide subscribe button when paused separately from subscribe button ([52d07ec](ReVanced/revanced-patches@52d07ec)) * **YouTube - Return YouTube Dislike:** Support version `18.37.36` ([ReVanced#3061](ReVanced/revanced-patches#3061)) ([fe11db7](ReVanced/revanced-patches@fe11db7)) * **YouTube:** Add `Disable fine scrubbing gesture` patch ([6c9baf2](ReVanced/revanced-patches@6c9baf2)) * **YouTube:** Bump compatibility to `18.38.44` ([ReVanced#3071](ReVanced/revanced-patches#3071)) ([a73868c](ReVanced/revanced-patches@a73868c))
Bug description
When trying to either copy or paste something the menu for it is too large which ends up blocking what the user is trying to cut/copy/paste in the first place. This behavior is only present within the ReVanced settings menu only.
Screenshots & Screencaptures
Within Revanced Settings:
Screen_Recording_20240421_190609_YouTube.mp4
Screen_Recording_20240421_190634_YouTube.mp4
Within YouTube:


Error logs
No response
Solution
No response
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: