Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge dev branch to main branch #996

Merged
merged 16 commits into from
Jul 10, 2023
Merged

chore: merge dev branch to main branch #996

merged 16 commits into from
Jul 10, 2023

Conversation

validcube
Copy link
Member

@validcube validcube commented Jul 5, 2023 •
edited by TheAabedKhan
Loading

Merge dev branch to main branch

Prerequisite before merge

  • Pull Request mark as ready (by author or the ReVanced Manager Team)
  • Approved by the Manager Team
  • Bump version to v1.3.9

16 Commits (1+4+3+5+2+1)

  • ✨ 1 Feature
  • 🐛 4 Bug Fixes
  • ⚙️ 3 Build Changes
  • ♻️ 5 Code Refactoring
  • 📝 2 Documentation Improvements
  • 🧹 1 Miscellaneous Change

ReVanced Manager v1.3.9 (Next)

Experienced in Kotlin? Consider checking out ReVanced Manager Compose!

validcube and others added 8 commits July 1, 2023 18:21
@validcube validcube linked an issue Jul 8, 2023 that may be closed by this pull request
bug: update option active when offline #986
Closed
4 tasks
TheAabedKhan
TheAabedKhan previously requested changes Jul 8, 2023
View reviewed changes
Copy link
Member

@TheAabedKhan TheAabedKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No semicolon on 119 and 120??

lib/ui/widgets/settingsView/settings_export_section.dart Show resolved Hide resolved
@validcube validcube linked an issue Jul 9, 2023 that may be closed by this pull request
bug: ReVanced Manager hangs with black screen since v1.3.7 when using a custom source #982
Closed
4 tasks
KobeW50 and others added 3 commits July 9, 2023 23:15
@KobeW50 @oSumAtrIX
docs: improve clarity of speech in issue template (#1005)
ecb54d8 
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
@TheAabedKhan
fix: fixed typo
9828857
@validcube
build: always compile with the latest SDK supported by Flutter
b272988 
`targetSdkVersion` is still the same, we want to test the application first before bumping up to latest.
@validcube validcube marked this pull request as ready for review July 10, 2023 11:43
@TheAabedKhan TheAabedKhan dismissed their stale review July 10, 2023 12:42

I forgot the =>

TheAabedKhan
TheAabedKhan approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@TheAabedKhan TheAabedKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great ✨

@validcube
build: update app version to v1.3.9
490a7a5 
ReVanced Manager, 1.3.9 (10030009)

See PR #996
@Ushie Ushie merged commit 48c878a into main Jul 10, 2023
schrobingus pushed a commit to schrobingus/revanced-manager that referenced this pull request Jul 27, 2023
@validcube @schrobingus
build: update app version to v1.3.9
3d0cdaf 
ReVanced Manager, 1.3.9 (10030009)

See PR ReVanced#996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAabedKhan TheAabedKhan TheAabedKhan approved these changes

@Ushie Ushie Awaiting requested review from Ushie

@Aunali321 Aunali321 Awaiting requested review from Aunali321

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@validcube @TheAabedKhan @Ushie @oSumAtrIX @KobeW50