bug: ReVanced Manager hangs with black screen since v1.3.7 when using a custom source

[Novgorod]

Type

Error while running the manager

Bug description

Phone: Samsung Glaxy S22 Ultra (Android 13, latest patch May 2023)

When using a custom source, the latest working version of ReVanced Manager is 1.3.6. It asks for all files permision on first run and then starts normally. After updating to 1.3.7 or 1.3.8 (while having a custom source in the settings) the screen stays black when running the app. I tried clean install, phone reboot and setting all prermissions prior to running the app, nothing works.

Side note: Downgrading to 1.3.6 doesn't work while a newer version is installed (invalid package), so I have to manually uninstall 1.3.8, only then I can install 1.3.6 which is the latest working version with a custom source.

Currently, the only "fix" is to downgrade to 1.3.6 as described, go to the settings and remove the custom source (set to default), then update to 1.3.8 because apparently the manager settings persist even after an uninstall. This is a separate issue which makes troubleshooting very difficult if the app breaks because of the settings and there is no obvious way to reset them.

Steps to reproduce

Install ReVanced Manager 1.3.7 or 1.3.8, set a custom source and run.

Android version

Android 13 (May 2023)

Manager version

1.3.7 and 1.3.8

Target package name

ReVanced Manager

Target package version.

1.3.7 and 1.3.8

Installation type

Non-root

Patches selected.

Device logs (exported using Manager settings).

-

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.
• The issue is related solely to the ReVanced Manager and not related to patching errors or patches

[Novgorod]

I just saw this issue - turns out mine is similar. I used a custom source before and the manager settings were preserved even after a complete uninstall, which is not a good idea if certain settings break the app.

Regardless, even if a custom source becomes incompatible, it should revert to defaults and not hang on startup...

[orfeous1]

Same here!
Black screen on 1.3.8 upgraded from 1.3.5
Custom source

[ILoveOpenSourceApplications]

It is indeed strange as the changelog from version 1.3.6 to 1.3.7 indicates that the possible reason for this issue is the bump to the patcher dependency.

[LisoUseInAIKyrios]

The ADB logs show this during startup:

flutter : [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: RangeError (length): Invalid value: Valid value range is empty: 0
flutter : #0      GithubAPI.getLatestRelease (package:revanced_manager/services/github_api.dart:68)
flutter : #1      GithubAPI.getLatestReleaseFile (package:revanced_manager/services/github_api.dart:123)
flutter : #2      GithubAPI.getPatches (package:revanced_manager/services/github_api.dart:146)
flutter : #3      ManagerAPI.getPatches (package:revanced_manager/services/manager_api.dart:211)
flutter : #4      PatcherAPI._loadPatches (package:revanced_manager/services/patcher_api.dart:49)
flutter : #5      PatcherAPI.initialize (package:revanced_manager/services/patcher_api.dart:32)
flutter : #6      main (package:revanced_manager/main.dart:27)

This was with the source set to my cloned patches and integrations (which neither have any releases)

[ILoveOpenSourceApplications]

v1.3.6 loads properly with custom source - inotia00. But not able to patch the recommended version of YouTube. Operation aborts mid way. Created another issue and posted log in there.

This has nothing to do with the manager. RVX hasn't updated it's patches to support the latest manager. So if you want to patch again you will have to rollback to the last supported manager version by RVX.

[validcube]

🎉 This issue have been fixed by #1003, please update to the latest version of ReVanced Manager (v1.3.9)

Feels free to reopen If you feels like the problem hasn't been resolved.