Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vm::stack allocations #5041

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Improve vm::stack allocations #5041

merged 2 commits into from
Aug 30, 2018

Conversation

Nekotekina
Copy link
Member

@Nekotekina Nekotekina commented Aug 26, 2018 •
edited
Loading

No description provided.

@Nekotekina Nekotekina changed the title Improve split file support Improve vm::stack allocations Aug 27, 2018
@Zangetsu38
Copy link
Contributor

all game is broken with stranbge error

·F 0:00:51.082518 LDR: class std::runtime_error thrown: VirtualProtect failed (00000001d0000000, 0x21000, addr=0x1d0000000, error=0x57)

@Nekotekina
Copy link
Member Author

Should be fixed.

@Zangetsu38
Copy link
Contributor

Zangetsu38 commented Aug 28, 2018 •
edited
Loading

Not fixed, same, log on your appveyor build
RPCS3.log.gz

@Nekotekina
sys_fs_stat: support split files
c49c7de 
Was forgotten after sys_fs_open
@Nekotekina
vm: allow 4k-aligned allocations for vm::stack
85fa094 
Fix utils::shm::map logic for MapViewOfFileEx
@Xcedf
Copy link

Xcedf commented Aug 30, 2018 •
edited
Loading

Using this Heavy Rain Demo works again
#4566 should be fixed now

@Nekotekina Nekotekina merged commit 85fa094 into RPCS3:master Aug 30, 2018
@AniLeo
Copy link
Member

AniLeo commented Aug 30, 2018

Likely #5038
Double check to make sure it's not a false regression report on this PR

@AniLeo AniLeo mentioned this pull request Aug 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nekotekina @Zangetsu38 @Xcedf @AniLeo