Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Mirror commit regression #4566

Closed
Xcedf opened this issue May 13, 2018 · 16 comments
Closed

Memory Mirror commit regression #4566

Xcedf opened this issue May 13, 2018 · 16 comments

Comments

@Xcedf
Copy link

Xcedf commented May 13, 2018

Found a few regressions
in 5d15d64

  1. Heavy Rain Demo [NPUA70112]
    F {PPU[0x1000009] Thread (Read Chunk Thread) [0x0056dc9c]} MEM: Access violation writing location 0xd00c08f0
  2. AMY [NPUB30613]
    F {PPU[0x10000c4] Thread (CInfoManagerPS3) [0x00705074]} MEM: Access violation writing location 0xd0330c50
    3)Gran Turismo HD Concept [NPEA90002] Speed regression
    before
    6
    after
    12
    did some extra debugging work for this on, since in the RP there were many versions of "Memory Mirror" i found out that 374dd7c has fine speed and b87d632 regressed, the reason in VirtualMemory.cpp changes between two versions
    There're maybe other regressions, but other my games seems to work fine
@Kravickas
Copy link
Contributor

Heavy Rain regressed like month ago but nvm

@jobs-git
Copy link

There is also regression in D3 BLUS31437, fps decreases on 2nd boot, this does not happen before Memory Mirror commit even when spu cache was implemented.

SPUASMJIT Recompiler
PPU LLVM Recompiler
Vulkan
Gtx 1060
AVX

@AniLeo
Copy link
Member

AniLeo commented May 20, 2018

Can someone confirm this is an issue in latest master and provide games that actually regressed on that PR and not on previous ones? (Apart from D3 report above)

@Xcedf
Copy link
Author

Xcedf commented May 20, 2018

The issue is still exist on the latest master, first two games went ingame for me on the commit before 5d15d64, and i did some more tests for these two games, i tested them on older versions of Memory Mirror, just in case if they may work, and they don't work exactly the same way

@kd-11 kd-11 mentioned this issue Jul 14, 2018
@kd-11
Copy link
Contributor

kd-11 commented Jul 14, 2018

Added a fix for the performance issues with #4876 which has now been merged. Should restore GT HD performance.

@Xcedf
Copy link
Author

Xcedf commented Jul 14, 2018

Confirm, the performance part fixed

@kroaton
Copy link

kroaton commented Aug 8, 2018

Fight Night Round 4 recently regressed with a "MEM Access Violation" warning as well though I'm not sure on what build it happened and if it's related to this problem.

The game used to be fully playable (apart from broken audio and occasional stutter) in #4424.

Force Cpu Blit does bypass the memory access violation but the player models are gone now (it might be some other regression or side effect of Force Cpu Blit).

@jobs-git
Copy link

I can confirm that the issue on D3 has already been fix in master.

@Xcedf
Copy link
Author

Xcedf commented Aug 30, 2018

All cases i've reported fixed now, closing this.
Thanks

@Xcedf Xcedf closed this as completed Aug 30, 2018
@Kravickas
Copy link
Contributor

Kravickas commented Aug 30, 2018

Heavy Rain still stucked before menu. I dont know how about u. Tho its not showing access violation for a long time.

@HenningJW
Copy link

Log?

@Kravickas
Copy link
Contributor

It need patch, so half fixed.

@RainbowCookie32
Copy link
Contributor

RPCS3.log.gz
Still not able to boot Heavy Rain Demo, PPU LLVM, SPU ASMJIT, OpenGL.

@AniLeo
Copy link
Member

AniLeo commented Aug 31, 2018

Of course you can't, you're using an older build...

@RainbowCookie32
Copy link
Contributor

Sh*t, I was sure I updated. Guess I'll test it again

@RainbowCookie32
Copy link
Contributor

And there it boots, I feel so dumb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants