-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Fixes #4869
rsx: Fixes #4869
Conversation
Fixes "WCB failing" regression in Uncharted 1 chapter 4 |
Attach traces. Renderdoc trace if rrc capture does not work. |
I see the problem, but I cannot recreate the steps that get there. Is it possible to grab an RRC capture? That would help replay the setup. |
No. It takes too much time to do that. |
That is unfortunate. Without any way of recreating this becomes near impossible to debug. Marking as WIP, maybe some other game will hit the same problem. |
gta v from vulkan rsx capture |
Should be fixed now. Retest for other possible regressions. |
This pr broke text in Resistance 3 [BCES01118] EDIT: as of 391aef4 the issue is fixed |
- Adds proper support for vertex textures, including dimensions other than 2D textures - Minor analyser fixup, removes spurious 'analyser failed' errors - Minor optimizations for program state tracking
Retest, should be fixed now. |
Yes, good is fixed |
F1 Race Stars doesn't want to go ingame with this PR if I use OpenGL + Write Color Buffers it just crashes RPCS3. Checked other games with OpenGL+WCB and they were fine. Vulkan works fine with WCB on this game too. RPCS3.zip Otherwise I checked around ~20 games with OGL+Vulkan and didn't notice any other issues from this PR. |
I checked F1, I can also trigger the crash on master. Its mechanism of failure is also unrelated (section leak between surface and texture caches) and Vulkan manages to get by because of luck. Fairly simple to fix, but that falls outside the scope of this PR. |
Ahh, sorry. I did check master but it only crashed on the PR :/ race conditions are fun. |
Dark souls II infinite shader compilation 20s ingame 9000+++ |
@spyropt Is it okay in the async PR? if it is i don't think there's much to worry about. |
@Asinin3 in the async pr it's ok but its missing the portrait on character selection |
Just press back or restart after reaching portraits or disable async if you really need the portraits. If you go back to the menu the shaders will have compiled and portraits will render fine. |
NOTE: Bumps shader cache version