Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Fixes #4869

Merged
merged 2 commits into from
Jul 12, 2018
Merged

rsx: Fixes #4869

merged 2 commits into from
Jul 12, 2018

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jul 9, 2018

NOTE: Bumps shader cache version

@Xcedf
Copy link

Xcedf commented Jul 9, 2018

Fixes "WCB failing" regression in Uncharted 1 chapter 4

@MarioSonic2987
Copy link
Contributor

GTA V regressed. It doesn't show anything ingame.

Before:
image
image

After:
image
image

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 10, 2018

Attach traces. Renderdoc trace if rrc capture does not work.

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 10, 2018

I see the problem, but I cannot recreate the steps that get there. Is it possible to grab an RRC capture? That would help replay the setup.

@MarioSonic2987
Copy link
Contributor

No. It takes too much time to do that.

@kd-11 kd-11 changed the title rsx: Fixes [WIP] rsx: Fixes Jul 10, 2018
@kd-11
Copy link
Contributor Author

kd-11 commented Jul 10, 2018

That is unfortunate. Without any way of recreating this becomes near impossible to debug. Marking as WIP, maybe some other game will hit the same problem.

@Kravickas
Copy link
Contributor

gta v from vulkan rsx capture
https://send.firefox.com/download/10b69cdba2/#2JGTErnhf_Tp5thqFyxIbg

@kd-11 kd-11 changed the title [WIP] rsx: Fixes rsx: Fixes Jul 11, 2018
@kd-11
Copy link
Contributor Author

kd-11 commented Jul 11, 2018

Should be fixed now. Retest for other possible regressions.

@MarioSonic2987
Copy link
Contributor

GTA V's regression is fixed.

image
image

@ZeeWanderer
Copy link
Contributor

ZeeWanderer commented Jul 11, 2018

This pr broke text in Resistance 3 [BCES01118]
master:
capture
pr:
capture_pr
dropbox->capture_pr.rar
RPCS3.log.gz
RPCS3_pr.log.gz
config used:
dropbox->config.yml

EDIT: as of 391aef4 the issue is fixed

- Adds proper support for vertex textures, including dimensions other than 2D textures
- Minor analyser fixup, removes spurious 'analyser failed' errors
- Minor optimizations for program state tracking
@kd-11
Copy link
Contributor Author

kd-11 commented Jul 11, 2018

Retest, should be fixed now.

@Zangetsu38
Copy link
Contributor

Yes, good is fixed

@Asinin3
Copy link
Contributor

Asinin3 commented Jul 11, 2018

F1 Race Stars doesn't want to go ingame with this PR if I use OpenGL + Write Color Buffers it just crashes RPCS3. Checked other games with OpenGL+WCB and they were fine. Vulkan works fine with WCB on this game too. RPCS3.zip
WCB doesn't actually fix any graphical issues with this game, but it's still a regression. Maybe there is some other games that were affected.

Otherwise I checked around ~20 games with OGL+Vulkan and didn't notice any other issues from this PR.

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 12, 2018

I checked F1, I can also trigger the crash on master. Its mechanism of failure is also unrelated (section leak between surface and texture caches) and Vulkan manages to get by because of luck. Fairly simple to fix, but that falls outside the scope of this PR.

@kd-11 kd-11 merged commit fa55a80 into RPCS3:master Jul 12, 2018
@Asinin3
Copy link
Contributor

Asinin3 commented Jul 12, 2018

Ahh, sorry. I did check master but it only crashed on the PR :/ race conditions are fun.

@spyropt
Copy link

spyropt commented Jul 12, 2018

Dark souls II infinite shader compilation 20s ingame 9000+++
RPCS3.log.gz

@Asinin3
Copy link
Contributor

Asinin3 commented Jul 13, 2018

@spyropt Is it okay in the async PR? if it is i don't think there's much to worry about.

@spyropt
Copy link

spyropt commented Jul 13, 2018

@Asinin3 in the async pr it's ok but its missing the portrait on character selection

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 13, 2018

Just press back or restart after reaching portraits or disable async if you really need the portraits. If you go back to the menu the shaders will have compiled and portraits will render fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants