Improve save data dialog #4377
Merged
Improve save data dialog #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks good, but I think the wording might need to be changed? New Saved Data > Save Data Personally I think the first option is better as writing "New" twice looks a little bit odd. |
|
Hmm, indeed. |
kd-11
approved these changes
Apr 2, 2018
Bug fix: don't display new data entry when not asked for Use icon/title provided by the game for the new data entry Display new data entry at the beginning of list when necessary Minor cellSaveData cleanup
|
|
Asinin3
approved these changes
Apr 2, 2018
|
Looks good, maybe just change the top line to "New Save Data" instead of "New Saved Data" ? |
|
It is not a string from code. |
|
It's not a string from code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't display new data when unnecessary (bug fix)
Use new data icon/title if provided by the game
Minor cellSaveData cleanup