Regression: Uncharted 1

[JohnHolmesII]

After pr #4377 trying to start a new game causes the following:

F {PPU[0x1000022] Thread (Save/Load Game Thread) [0x00180ee8]} MEM: Access violation reading location 0x0

Loading a save doesn't seem to trigger any problems. It's only new game.

[Zangetsu38]

Oh Good i have signaled this tonight so i am not alone

[JohnHolmesII]

The error comes from this line in overlays.h (395)
new_stub = std::make_unique<save_dialog_entry>(title, "Select to create a new entry", id, icon);

[Margen67]

@JohnHolmesII Did you try disabling the native UI?

[JohnHolmesII]

Well of course it works fine, I know what the problem is. I just have no idea how to fix it. I'll come up with something.

[JohnHolmesII]

So the problem seems to be this line:
title = picon->title.get_ptr(); (overlays.h, 380)

title was already set to "Create New", but then its gets overwritten here. printing picon->title shows 0 in the log, though that could be a an endianess bit of joy. Then again, maybe not.

Printing title after that line returns 2^32 exactly.

Any ideas?

[jjsat]

If pcon->title is null (could be), then adding a check for just that should do the trick?

if (picon->title)
  title = picon->title.get_ptr();

[JohnHolmesII]

I could. I just don't really understand what the code is doing, i.e. what is title supposed to be? Is icon the actual icon that gets displayed in the save dialog? Is picon->title supposed to be the name of the resource?

@kd-11 can you shed any light on this, since I believe you wrote it?

[MSuih]

what is title supposed to be?

The title for creating a new save. "New saved data" in this image

Is icon the actual icon that gets displayed in the save dialog? Is picon->title supposed to be the name of the resource?

Yes, variable icon is the icon that's actually shown on new save entry. picon->title is the title for new save that comes from the game. I guess that some dev's arent interested in providing a custom title so they send a null instead and system is supposed to show locale default in that case.

[JohnHolmesII]

Well actually for previously made saves the title shows up in the box as the name of the game. I think it looks good without it. I'll open a pr for more feedback.

[kd-11]

Thanks. neko recently updated the code recently to use custom "new save" image and text which is why the regression only appeared recently. Should be fixed now.