task0{3,4,7}: Add tests for IPv6 fragmentation #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall, this addition looks appropriate to me. I think the multi-hop UDP test is a valuable real world scenario. |
|
I ran the new tests for tasks 3 and 4. My only question was which example/test to run, and I see the example guide already specifies tests/gnrc_udp. In the interest of time I did not run task 7, but the instructions look clear enough. The new tests seem like a reasonable extension of the existing tests. |
|
My only concern is generically setting the larger pktbuf size in test/gnrc_udp, as commented in RIOT-OS/RIOT#12375. Let's resolve that, and then we can resolve here. |
kb2ma
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #137
Requires RIOT-OS/RIOT#12375 for simple deployment