cpu/sam3: optimize gpio ISR processing #21179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dylad <dylan.laduranty@mesotic.com>
benpicco
approved these changes
Feb 5, 2025
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR makes use of
bitarithm_test_and_clearto process gpio ISR instead of looping through every bits inside the register.It will use
CLZARM instruction to catch the position of all bits set and clear them one by one which is faster than checking every bits every time.Testing procedure
Tested on
arduino-duewithtests/buttons(I've wired up 4 external buttons with a breadboard for this).Issues/PRs references
None