Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: define the interrupt flank for BTN0 for ESP32 Heltec Lora32 V2 #13747

Merged
merged 1 commit into from
Mar 29, 2020
Merged

boards: define the interrupt flank for BTN0 for ESP32 Heltec Lora32 V2 #13747

merged 1 commit into from
Mar 29, 2020

Conversation

gschorcht
Copy link
Contributor

Contribution description

With PR #13655, a default GPIO interrupt flank was introduced for test applications. Since PR #11265 with Heltec WiFi LoRa 32 V2 board definition was provided before but merged after PR #13655, it didn't contain contain this definition.

This PR defines GPIO_FALLING as default interrupt flank for BTN0.

Testing procedure

If a Heltec WiFi LoRa 32 V2 board is at hand, use tests/periph_pm to test. This test application defines GPIO_RISING as default interrupt flank if it is not overriden by the board definition.

make BOARD=esp32-heltec-lora32-v2 -C tests/periph_pm flash term

With the current master the button interrupt is generated when the button is released since the GPIO for BTN is pulled up. With this PR the button interrupt is generated when the button is pressed.

Issues/PRs references

Provides the default interrupt definition for PR #13655.

@gschorcht gschorcht added Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Mar 29, 2020
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 29, 2020
@benpicco benpicco merged commit 48eaef7 into RIOT-OS:master Mar 29, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Apr 3, 2020
@gschorcht gschorcht deleted the boards/esp32-heltec-lora-v2 branch June 25, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @benpicco @leandrolanzieri