-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/esp32: adds Heltec WiFi LoRa 32 V2 board definition #11265
Conversation
@@ -0,0 +1 @@ | |||
include $(RIOTBOARD)/common/esp32/Makefile.dep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you could also add (maybe it has other implication with esp stuff ?):
ifneq (,$(filter netdev_default,$(USEMODULE)))
USEMODULE += sx1276
endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, ..., not sure what the most usual case is. Default network interface might be also esp_now
or esp_wifi
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it either or?
With this you'd get both sx1276
and esp_now
.
But this can be added when #12994 is merged so the user doesn't have to be careful not to forget to adding GNRC_NETIF_NUMOF=2
, or else run into an assert failure when the pre-allocated netif slots run out.
071b31e
to
d793b7a
Compare
@yegorich Squased. |
d793b7a
to
203c936
Compare
release status ping, should I change the milestone? |
@MrKevinWeiss Sorry for late answer, I'm quite busy at the moment. From my point of view, it is ready for release. I'm just waiting for a trigger to squash it. |
1 similar comment
@MrKevinWeiss Sorry for late answer, I'm quite busy at the moment. From my point of view, it is ready for release. I'm just waiting for a trigger to squash it. |
Does anyone else have this board? If not I can add it to the wishlist but then I don't think it will get in to this release. Please advise otherwise I will move the milestone. |
I think we can wait until next release for this one. |
@gschorcht if you can run |
@gschorcht I think, the only thing missing is |
Yes, it will become a problem once I rebased it. |
492e49c
to
18e8b6b
Compare
With the last commit, I added a small section on how to use the board's display. |
ee9ec06
to
79c8f43
Compare
May I squash this PR? |
More than a month has passed, I'd say it's safe to squash 😉 |
79c8f43
to
b67c330
Compare
b67c330
to
7ae4248
Compare
Squashed. But I have removed the Another question remains. @aabadie suggested to use ifneq (,$(filter netdev_default,$(USEMODULE)))
USEMODULE += sx1276
endif This would mean that it would pull in |
b0cf48b
to
948c45d
Compare
You can squash again 😉 |
fixup! boards/esp32: Heltec WiFi LoRa 32 V2 board added fixup! boards/esp32: Heltec WiFi LoRa 32 V2 board added
a88f4e9
to
b16ff57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just contains definitions for common code, very straightforward.
Enabling the sx1276
radio can be done when having more than one network interface enabled by default doesn't require additional user configuration.
@benpico Thanks for reviewing and merging. |
Contribution description
This PR adds the board definition for Heltec WiFi LoRa 32 V2 board. Heltec WiFi LoRa 32 V2 is an ESP32 development board with 8 MB Flash that uses the EPS32 chip directly. It integrates
Many GPIOs are broken out. Since the board is open source hardware, a number of clones are available.
Testing procedure
Application
examples/lorawan
can be used to test the board including the LoRaWAN functionality.Issues/PRs references
Depends on PR #13685