Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds matchers for Swift 5 Result type #643

Merged
merged 4 commits into from
May 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Nimble.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@
0477153523B740AD00402D4E /* DispatchTimeInterval.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0477153423B740AD00402D4E /* DispatchTimeInterval.swift */; };
0477153623B740B700402D4E /* DispatchTimeInterval.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0477153423B740AD00402D4E /* DispatchTimeInterval.swift */; };
0477153723B740B800402D4E /* DispatchTimeInterval.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0477153423B740AD00402D4E /* DispatchTimeInterval.swift */; };
106112BD2251DFE7000A5848 /* BeResult.swift in Sources */ = {isa = PBXBuildFile; fileRef = 106112BC2251DFE7000A5848 /* BeResult.swift */; };
106112C02251E0FA000A5848 /* BeResult.swift in Sources */ = {isa = PBXBuildFile; fileRef = 106112BC2251DFE7000A5848 /* BeResult.swift */; };
106112C22251E0FD000A5848 /* BeResult.swift in Sources */ = {isa = PBXBuildFile; fileRef = 106112BC2251DFE7000A5848 /* BeResult.swift */; };
106112C52251E13B000A5848 /* BeResultTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 106112C42251E13B000A5848 /* BeResultTest.swift */; };
106112C62251E13B000A5848 /* BeResultTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 106112C42251E13B000A5848 /* BeResultTest.swift */; };
106112C72251E13B000A5848 /* BeResultTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 106112C42251E13B000A5848 /* BeResultTest.swift */; };
1F0648CC19639F5A001F9C46 /* ObjectWithLazyProperty.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1F0648CB19639F5A001F9C46 /* ObjectWithLazyProperty.swift */; };
1F0648CD19639F5A001F9C46 /* ObjectWithLazyProperty.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1F0648CB19639F5A001F9C46 /* ObjectWithLazyProperty.swift */; };
1F0648D41963AAB2001F9C46 /* SynchronousTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1F0648D31963AAB2001F9C46 /* SynchronousTest.swift */; };
Expand Down Expand Up @@ -504,6 +510,8 @@

/* Begin PBXFileReference section */
0477153423B740AD00402D4E /* DispatchTimeInterval.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DispatchTimeInterval.swift; sourceTree = "<group>"; };
106112BC2251DFE7000A5848 /* BeResult.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BeResult.swift; sourceTree = "<group>"; };
106112C42251E13B000A5848 /* BeResultTest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BeResultTest.swift; sourceTree = "<group>"; };
1F0648CB19639F5A001F9C46 /* ObjectWithLazyProperty.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ObjectWithLazyProperty.swift; sourceTree = "<group>"; };
1F0648D31963AAB2001F9C46 /* SynchronousTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SynchronousTest.swift; sourceTree = "<group>"; };
1F14FB63194180C5009F2A08 /* utils.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = utils.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -830,6 +838,7 @@
1F925F0A195C18E100ED456B /* BeLessThanTest.swift */,
1F925EEE195C136500ED456B /* BeLogicalTest.swift */,
1F925EF8195C175000ED456B /* BeNilTest.swift */,
106112C42251E13B000A5848 /* BeResultTest.swift */,
1F91DD2C1C74BF36002C309F /* BeVoidTest.swift */,
857D184D2536123F00D8693A /* BeWithinTest.swift */,
7B13BA091DD360DE00C9098C /* ContainElementSatisfyingTest.swift */,
Expand Down Expand Up @@ -883,6 +892,7 @@
1FD8CD161968AB07008ED995 /* BeLessThanOrEqual.swift */,
1FD8CD171968AB07008ED995 /* BeLogical.swift */,
1FD8CD181968AB07008ED995 /* BeNil.swift */,
106112BC2251DFE7000A5848 /* BeResult.swift */,
1F91DD301C74BF61002C309F /* BeVoid.swift */,
857D1848253610A900D8693A /* BeWithin.swift */,
1FD8CD1A1968AB07008ED995 /* Contain.swift */,
Expand Down Expand Up @@ -1341,6 +1351,7 @@
CDFB6A401F7E082500AD8CC7 /* CwlDarwinDefinitions.swift in Sources */,
1FD8CD401968AB07008ED995 /* BeCloseTo.swift in Sources */,
1F1871C81CA89EDB00A34BF2 /* NMBExceptionCapture.m in Sources */,
106112C02251E0FA000A5848 /* BeResult.swift in Sources */,
1FD8CD361968AB07008ED995 /* Expectation.swift in Sources */,
1FD8CD321968AB07008ED995 /* NimbleXCTestHandler.swift in Sources */,
1F43728F1A1B344000EB80F8 /* Stringers.swift in Sources */,
Expand Down Expand Up @@ -1453,6 +1464,7 @@
1F299EAB19627B2D002641AF /* BeEmptyTest.swift in Sources */,
7B13BA111DD361EB00C9098C /* ObjCContainElementSatisfyingTest.m in Sources */,
1F925EF6195C147800ED456B /* BeCloseToTest.swift in Sources */,
106112C62251E13B000A5848 /* BeResultTest.swift in Sources */,
1F4A56791A3B32E3009E1637 /* ObjCBeGreaterThanOrEqualToTest.m in Sources */,
A8A3B6F6207329DD00E25A08 /* SatisfyAllOfTest.swift in Sources */,
AE7ADE491C80C00D00B94CD3 /* MatchErrorTest.swift in Sources */,
Expand Down Expand Up @@ -1530,6 +1542,7 @@
1F5DF17A1BDCA0F500C3A531 /* BeEmpty.swift in Sources */,
1F5DF18C1BDCA0F500C3A531 /* Await.swift in Sources */,
1F1871D81CA89EEF00A34BF2 /* NMBStringify.m in Sources */,
106112C22251E0FD000A5848 /* BeResult.swift in Sources */,
1F5DF1821BDCA0F500C3A531 /* BeNil.swift in Sources */,
1F5DF16F1BDCA0F500C3A531 /* AssertionDispatcher.swift in Sources */,
964CFEFF1C4FF48900513336 /* ThrowAssertion.swift in Sources */,
Expand Down Expand Up @@ -1595,6 +1608,7 @@
1F5DF1A61BDCA10200C3A531 /* EndWithTest.swift in Sources */,
CD79C9A31D2CC841004B6F9A /* ObjCBeFalseTest.m in Sources */,
1F5DF1A71BDCA10200C3A531 /* EqualTest.swift in Sources */,
106112C72251E13B000A5848 /* BeResultTest.swift in Sources */,
CD79C9AA1D2CC848004B6F9A /* ObjCBeLessThanOrEqualToTest.m in Sources */,
1F5DF1931BDCA10200C3A531 /* SynchronousTest.swift in Sources */,
CD79C9A11D2CC83B004B6F9A /* ObjCBeCloseToTest.m in Sources */,
Expand Down Expand Up @@ -1630,6 +1644,7 @@
CDFB6A3F1F7E082500AD8CC7 /* CwlDarwinDefinitions.swift in Sources */,
1FD8CD411968AB07008ED995 /* BeCloseTo.swift in Sources */,
1F1871D31CA89EEE00A34BF2 /* NMBExceptionCapture.m in Sources */,
106112BD2251DFE7000A5848 /* BeResult.swift in Sources */,
1FD8CD371968AB07008ED995 /* Expectation.swift in Sources */,
1FD8CD331968AB07008ED995 /* NimbleXCTestHandler.swift in Sources */,
1F43728E1A1B343F00EB80F8 /* Stringers.swift in Sources */,
Expand Down Expand Up @@ -1751,6 +1766,7 @@
857D184F2536124400D8693A /* BeWithinTest.swift in Sources */,
1F925EE7195C121200ED456B /* AsynchronousTest.swift in Sources */,
1F0648CD19639F5A001F9C46 /* ObjectWithLazyProperty.swift in Sources */,
106112C52251E13B000A5848 /* BeResultTest.swift in Sources */,
1F4A56861A3B33A0009E1637 /* ObjCBeTruthyTest.m in Sources */,
DD9A9A9019CF43AD00706F49 /* BeIdenticalToObjectTest.swift in Sources */,
1F4BB8B61DACA0E30048464B /* ThrowAssertionTest.swift in Sources */,
Expand Down
32 changes: 32 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ expect(ocean.isClean).toEventually(beTruthy())
- [Collection Elements](#collection-elements)
- [Collection Count](#collection-count)
- [Notifications](#notifications)
- [Result](#result)
- [Matching a value to any of a group of matchers](#matching-a-value-to-any-of-a-group-of-matchers)
- [Custom Validation](#custom-validation)
- [Writing Your Own Matchers](#writing-your-own-matchers)
Expand Down Expand Up @@ -1197,6 +1198,37 @@ expect {

> This matcher is only available in Swift.

## Result

```swift
// Swift
let aResult: Result<String, Error> = .success("Hooray")

// passes if result is .success
expect(aResult).to(beSuccess())

// passes if result value is .success and validates Success value
expect(aResult).to(beSuccess { value in
expect(value).to(equal("Hooray"))
})


enum AnError: Error {
case somethingHappened
}
let otherResult: Result<String, AnError> = .failure(.somethingHappened)

// passes if result is .failure
expect(otherResult).to(beFailure())

// passes if result value is .failure and validates error
expect(otherResult).to(beFailure { error in
expect(error).to(matchError(AnError.somethingHappened))
})
```

> This matcher is only available in Swift.

## Matching a value to any of a group of matchers

```swift
Expand Down
67 changes: 67 additions & 0 deletions Sources/Nimble/Matchers/BeResult.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
import Foundation

/// A Nimble matcher for Result that succeeds when the actual value is success.
///
/// You can pass a closure to do any arbitrary custom matching to the value inside result.
/// The closure only gets called when the result is success.
public func beSuccess<Success, Failure>(
test: ((Success) -> Void)? = nil
) -> Predicate<Result<Success, Failure>> {
return Predicate.define { expression in
var rawMessage = "be <success(\(Success.self))>"
if test != nil {
rawMessage += " that satisfies block"
}
let message = ExpectationMessage.expectedActualValueTo(rawMessage)

guard case let .success(value)? = try expression.evaluate() else {
return PredicateResult(status: .doesNotMatch, message: message)
}

var matches = true
if let test = test {
let assertions = gatherFailingExpectations {
test(value)
}
let messages = assertions.map { $0.message }
if !messages.isEmpty {
matches = false
}
}

return PredicateResult(bool: matches, message: message)
}
}

/// A Nimble matcher for Result that succeeds when the actual value is failure.
///
/// You can pass a closure to do any arbitrary custom matching to the error inside result.
/// The closure only gets called when the result is failure.
public func beFailure<Success, Failure>(
test: ((Failure) -> Void)? = nil
) -> Predicate<Result<Success, Failure>> {
return Predicate.define { expression in
var rawMessage = "be <failure(\(Failure.self))>"
if test != nil {
rawMessage += " that satisfies block"
}
let message = ExpectationMessage.expectedActualValueTo(rawMessage)

guard case let .failure(error)? = try expression.evaluate() else {
return PredicateResult(status: .doesNotMatch, message: message)
}

var matches = true
if let test = test {
let assertions = gatherFailingExpectations {
test(error)
}
let messages = assertions.map { $0.message }
if !messages.isEmpty {
matches = false
}
}

return PredicateResult(bool: matches, message: message)
}
}
104 changes: 104 additions & 0 deletions Tests/NimbleTests/Matchers/BeResultTest.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
import XCTest
import Nimble

private struct StubError: Error, CustomDebugStringConvertible {
let debugDescription = "StubError"
}

enum TestError: Error, Equatable, CustomDebugStringConvertible {
case foo, bar

var debugDescription: String {
switch self {
case .foo:
return "TestError.foo"
case .bar:
return "TestError.bar"
}
}
}

final class BeSuccessTest: XCTestCase {
func testPositiveMatch() {
let result: Result<Int, Error> = .success(1)
expect(result).to(beSuccess())
}

func testPositiveMatchWithClosure() {
let stubValue = 1
let result: Result<Int, Error> = .success(stubValue)
expect(result).to(beSuccess { value in
expect(value).to(equal(stubValue))
})
}

func testPositiveNegatedMatch() {
let result: Result<Int, Error> = .failure(StubError())
expect(result).toNot(beSuccess())
}

func testNegativeMatches() {
failsWithErrorMessage("expected to be <success(Int)>, got <failure(StubError)>") {
let result: Result<Int, Error> = .failure(StubError())
expect(result).to(beSuccess())
}
failsWithErrorMessage("expected to not be <success(Int)>, got <success(1)>") {
let result: Result<Int, Error> = .success(1)
expect(result).toNot(beSuccess())
}

failsWithErrorMessage("expected to be <success(Int)> that satisfies block, got <success(1)>") {
let result: Result<Int, Error> = .success(1)
expect(result).to(beSuccess { _ in
fail()
})
}
}
}

final class BeFailureTest: XCTestCase {
func testPositiveMatch() {
let result: Result<Int, Error> = .failure(StubError())
expect(result).to(beFailure())
}

func testPositiveMatchWithClosure() {
let result: Result<Int, Error> = .failure(StubError())
expect(result).to(beFailure { error in
expect(error).to(matchError(StubError.self))
})

expect(Result<Int, TestError>.failure(.foo)).to(beFailure { error in
expect(error).to(equal(.foo))
})
}

func testPositiveNegatedMatch() {
let result: Result<Int, Error> = .success(1)
expect(result).toNot(beFailure())
}

func testNegativeMatches() {
failsWithErrorMessage("expected to be <failure(Error)>, got <success(1)>") {
let result: Result<Int, Error> = .success(1)
expect(result).to(beFailure())
}
failsWithErrorMessage("expected to not be <failure(Error)>, got <failure(StubError)>") {
let result: Result<Int, Error> = .failure(StubError())
expect(result).toNot(beFailure())
}

failsWithErrorMessage("expected to be <failure(Error)> that satisfies block, got <failure(StubError)>") {
let result: Result<Int, Error> = .failure(StubError())
expect(result).to(beFailure { _ in
fail()
})
}
failsWithErrorMessage("expected to be <failure(TestError)> that satisfies block, got <failure(TestError.foo)>") {
let result: Result<Int, TestError> = .failure(.foo)
expect(result).to(beFailure { error in
expect(error).to(equal(.bar))
})
}
}
}