-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds matchers for Swift 5 Result type #643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesyo
reviewed
Apr 2, 2019
houndci-bot
reviewed
Apr 3, 2019
houndci-bot
reviewed
Apr 8, 2019
houndci-bot
reviewed
Apr 8, 2019
kamitchell
reviewed
Jul 27, 2019
For what it's worth, I'm using these as my local custom func beFailure<Success, Failure>() -> Predicate<Result<Success, Failure>> {
return Predicate.simple("be failure") { actualExpression in
guard let actual = try actualExpression.evaluate(), case .failure = actual else {
return .doesNotMatch
}
return .matches
}
}
func beSuccess<Success, Failure>() -> Predicate<Result<Success, Failure>> {
return Predicate.simple("be success") { actualExpression in
guard let actual = try actualExpression.evaluate(), case .success = actual else {
return .doesNotMatch
}
return .matches
}
} |
Sorry for the late, I'm rebooting this now for Nimble v9. |
d6e0345
to
01de2ed
Compare
ikesyo
reviewed
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll tackle the feedbacks myself.
44a1eec
to
564811c
Compare
ikesyo
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5 adds common Result type. It's useful to have matchers out of the box in Nimble.
This PR adds matchers beSuccess and beFailure. This is purely additive changes with full test coverage. Also added some code samples into Readme.