Admittance/impedance marker data management at Smith chart diagrams #701
Conversation
|
I've tested 428b687 and it's fine. |
|
I've added the options to show also the series and parallel equivalent components values:
|
|
Reviewed and tested locally. It works fine. However, I think I've found a bug... When the marker is about to cross the inductive/capacitive border it jumps to the center of the Smith chart, it stays there for a while and then it continues following the curve trace (it's quite weird...). Please, see the following screencast: https://drive.google.com/open?id=0BwDjrwGfd_z7SFYxUHYtNFBrdVU Notice that the marker reading is correct though... |
|
thanks for the fast review, while testing I saw the same issue and fixed it after pushing to this PR. I was not sure if it should go to a separate PR, it's just a small thing here; the |
was recently pointed out at qucs-devel mail list that this makes little sense. In this commit, this behaviour is fixed so that markers show impedance/admittance data at impedance/admittance Smith charts by default.
to the Smith charts marker optional text. Reworked the marker text options handling to keep them in a single variable/field.
values for the Smith charts markers
used e.g. to check whether the marker pointer is inside a chart and so should be drawn or just point to the diagram center. The current code was not correct for locations very close to the circle boundary.
274c59a to
86b343f
Compare
So far, when placing a marker at a Smith chart diagram (both impedance and admittance types), the markers always show S-par and impedance data. In this sense, this PR fixes this and includes a new option in marker dialog so as to let the user decide which of these parameters (impedance, admittance, both or none) wants to see.
The default behavior is to show impedance data at conventional Smith charts and admittance data at admittance Smith chart diagrams.
It was added two extra fields ('display admittance' and 'display impedance') to the format employed to save the marker settings on the .dpl file.
I'll try to implement this feature in #407 soon. After that, if #407 gets merged, this PR can be closed.