Correct impedance to admittance conversion formula

Qucs · Jul 29, 2017 · 428b687 · 428b687
1 parent e3e74a0
commit 428b687
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/qucs/qucs/diagrams/smithdiagram.cpp b/qucs/qucs/diagrams/smithdiagram.cpp
@@ -144,7 +144,13 @@ QString SmithDiagram::extraMarkerText(Marker const* m) const
   Zi = m->powImag();
 
   MatchDialog::r2z(Zr, Zi, Z0);
-  Yr = 1/Zr; Yi = 1/Zi;//The impedance data are converted into admittance.
+  // convert impedance to admittance
+  Yr = Zr; Yi = Zi;
+  MatchDialog::c2p(Yr, Yi);
+  Yr = 1.0 / Yr; // magnitude
+  Yi = -Yi; // angle
+  MatchDialog::p2c(Yr, Yi);
+
   QString Var = pGraph->Var;
   QString Var_ =Var;