Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rearrange library symbols (WIP) #592

Closed
wants to merge 22 commits into from
Closed

rearrange library symbols (WIP) #592

wants to merge 22 commits into from

Conversation

felix-salfelder
Copy link
Member

followup to #556 (hotfix merged). trying to rearrange library symbols.

this definitely needs work. there's some overlap with other PRs requiring symbol.h

andresmmera and others added 22 commits November 6, 2016 01:14
@felix-salfelder
Fix for issues Qucs#550 and Qucs#553
5c4b6dc 
This PR fixes both issues Qucs#550 and Qucs#553. It was found that QucsLib tool
didn't update neither the default symbol nor the name/library of the
selected component
@felix-salfelder
Load the default symbol only when required...
d0d631d
@felix-salfelder
Replaced LoadDefaultSymbol() code
1a50d2f 
LoadDefaultSymbol() was removed and its code was placed where the
function was called.
@felix-salfelder
Relocated the code for loading the default symbol
79a082d 
The code for reloading the default symbol was moved to SymbolWidget
class.
@felix-salfelder
introduce symbol class. (start to) use it in qucslib
ddf650c
@felix-salfelder
Trying to compile QucsLib with Symbol class. Step 1
c5b5921
@felix-salfelder
move settings to settings header.
8c9bc68 
(did not compile, some redefinition?!)
@felix-salfelder
trying to de-convolute symbol-widget and drawing.
233c235 
don't know what DragNDropWidth is..
@felix-salfelder
fix symbol.h caption
3d74322
@felix-salfelder
stash
5c08f35
@felix-salfelder
Moved back and forth includes
7abca6c 
Before this commit, an error related to QucsSettings object remained
there...

It seems that, apart from the QWidget issue, the rest of the code do not
cause errors.
@felix-salfelder
this now compiles and links. needs more cleanup.
748f0ef 
watch out for BUG and FIXME...
@felix-salfelder
more cleanup
6533b23
@felix-salfelder
move more parse code to libcomp
08fdc24
@felix-salfelder
allow to override wrong path to .lib files
89ea3c8 
now works with
$ make
$ QUCS_LIBRARY=../qucs-lib/library/ qucs-lib/qucslib
@felix-salfelder
much better, some symbols dimensions seem to be wrong.
66466eb
@felix-salfelder
qucscomp: changes from pastebin
f4e122d
@felix-salfelder
cleanup. trying to debug width and height.
903407d
@felix-salfelder
more cleanup. something is wrong with symbol dimensions.
4b19bfb
@felix-salfelder
unbreak some symbols (missing parens in constructor).
4347c3d 
and remove some non-symbol text from symbols
@felix-salfelder
use painter for drawing symbols. also draw some text (WIP)
86f6a9b 
some symbols (diode, JFET) dont paint (why?)
@felix-salfelder
don't include cstddef, as it confuses "abs" on some platforms
517cce7
@felix-salfelder felix-salfelder mentioned this pull request Nov 6, 2016
Closed
@guitorri guitorri added this to the 0.0.20 milestone Nov 23, 2016
@guitorri guitorri changed the base branch from release-0.0.19 to develop January 22, 2017 13:22
@guitorri
Copy link
Member

Moved base to develop.

@guitorri
Copy link
Member

guitorri commented Oct 6, 2017

It seems some work is still needed. Moving it forward.

@guitorri guitorri modified the milestones: 0.0.20, 0.0.21 Oct 6, 2017
@felix-salfelder felix-salfelder mentioned this pull request Jul 22, 2020
Closed
38 tasks
@felix-salfelder
Copy link
Member Author

obsolete with #898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
qucs-lib
Projects
None yet
Milestone
0.0.21
Development

Successfully merging this pull request may close these issues.
2 participants
@felix-salfelder @guitorri