Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad components preview in "Qucs Library Tool 0.0.19" #550

Closed
pidgeon777 opened this issue Jul 24, 2016 · 4 comments
Closed

Bad components preview in "Qucs Library Tool 0.0.19" #550

pidgeon777 opened this issue Jul 24, 2016 · 4 comments
Milestone
0.0.19

Comments

@pidgeon777
Copy link

When selecting a component in the Qucs Library Tool window, sometimes the preview of the component is wrong.
Steps to reproduce the problem:

  1. Tools -> Component Library (CTRL + 5).

image

  1. Digit "741" (with no quotes) in the search box, and select the first result.

image

  1. Press arrow down in the keyboard.

image

  1. Press arrow down in the keyboard.

image

  1. Press arrow down in the keyboard.

image

  1. Press arrow down in the keyboard.

image

  1. Press arrow down in the keyboard.

image

  1. Press arrow down in the keyboard.

image

  1. Press arrow down in the keyboard.

image

  1. Press arrow down in the keyboard.

image

  1. Press arrow down in the keyboard.

image

You can notice how, in many cases, the preview of the selected component is wrong.
I'm using Qucs v0.0.19 (qucs-win64-bin portable version), running it on a Windows 7 x64 machine.
@in3otd
Copy link
Contributor

in3otd commented Jul 24, 2016

this is almost surely related to #543... I did port the search code from the GUI to the Library Tool...

@in3otd in3otd mentioned this issue Aug 12, 2016
Closed
andresmmera pushed a commit to andresmmera/qucs that referenced this issue Aug 15, 2016
Fix for issues Qucs#550 and Qucs#553
1ab5488 
This PR fixes both issues Qucs#550 and Qucs#553. It was found that QucsLib tool
didn't update neither the default symbol nor the name/library of the
selected component
@andresmmera andresmmera mentioned this issue Aug 15, 2016
Closed
@andresmmera
Copy link
Contributor

I reckon that #556 solves the problem. Just for checking, could you test it?

@pidgeon777
Copy link
Author

Unfortunately I'm not able to test it at the moment.

guitorri pushed a commit to guitorri/qucs that referenced this issue Nov 3, 2016
@guitorri
Fix for issues Qucs#550 and Qucs#553
c08a6b7 
It was found that QucsLib tool didn't update neither the default
symbol nor the name/library of the selected component.

LoadDefaultSymbol() was removed and its code was placed where the
function was called.

The code for reloading the default symbol was moved to SymbolWidget
class.
@guitorri guitorri added this to the 0.0.19 milestone Nov 3, 2016
guitorri added a commit that referenced this issue Nov 4, 2016
@guitorri
Merge pull request #580 from guitorri/rebase-PR556
7278ccf 
Fix for issues #550 and #553
@guitorri
Copy link
Member

guitorri commented Nov 4, 2016

Fix merged with #580.

@guitorri guitorri closed this as completed Nov 4, 2016
felix-salfelder pushed a commit to felix-salfelder/qucs that referenced this issue Nov 6, 2016
@felix-salfelder
Fix for issues Qucs#550 and Qucs#553
5c4b6dc 
This PR fixes both issues Qucs#550 and Qucs#553. It was found that QucsLib tool
didn't update neither the default symbol nor the name/library of the
selected component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.19
Development

No branches or pull requests
4 participants
@guitorri @in3otd @andresmmera @pidgeon777