-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for rustworkx.visit annotations #1362
Merged
mtreinish
merged 7 commits into
Qiskit:main
from
IvanIsCoding:even-more-visit-annotation-fixes
Jan 15, 2025
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4a00656
Improvements for rustworkx.visit annotations
IvanIsCoding 2621dfc
Black
IvanIsCoding 37bbdd6
Remove double import sys
IvanIsCoding 499ea56
Add overloads
IvanIsCoding 4c800f7
Another fix
IvanIsCoding 9ad808f
Revert "Add overloads"
IvanIsCoding aa9bdb9
Revert visitor defaults
IvanIsCoding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,17 @@ | |
|
||
from typing import Any, Generic, TypeVar | ||
|
||
import sys | ||
|
||
if sys.version_info >= (3, 13): | ||
from typing import TypeVar | ||
else: | ||
from typing_extensions import TypeVar | ||
|
||
class StopSearch(Exception): ... | ||
class PruneSearch(Exception): ... | ||
|
||
_T = TypeVar("_T") | ||
_T = TypeVar("_T", default=Any) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This silences pyright in strict mode like reported in #1352 |
||
|
||
class BFSVisitor(Generic[_T]): | ||
def discover_vertex(self, v: int) -> Any: ... | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not strictly necessary but I noticed we could refactor this to avoid depending on
typing_extension
for 3.13