Improvements for rustworkx.visit annotations #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIsCoding
commented
Jan 15, 2025
| @@ -42,6 +39,11 @@ if sys.version_info >= (3, 13): | |||
| else: | |||
| from typing_extensions import TypeVar | |||
|
|
|||
| if sys.version_info >= (3, 11): | |||
There was a problem hiding this comment.
This is not strictly necessary but I noticed we could refactor this to avoid depending on typing_extension for 3.13
| class StopSearch(Exception): ... | ||
| class PruneSearch(Exception): ... | ||
|
|
||
| _T = TypeVar("_T") | ||
| _T = TypeVar("_T", default=Any) |
There was a problem hiding this comment.
This silences pyright in strict mode like reported in #1352
IvanIsCoding
commented
Jan 15, 2025
This reverts commit 499ea56.
|
Overloading is harder than I thought. https://github.com/Qiskit/rustworkx/actions/runs/12780463862/job/35626988746 had quite a lot of errors. Let's try to merge a smaller PR first with some obvious, correct improvements. I will study more on the overloads side to try to fix the issues in a separate PR. edit: I described a possible fix in #1361 (comment). So indeed, we'll need a separate PR. Let's keep this one simple |
mtreinish
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1352 and #1361
This is kind of a mix of using
TypeVar's default argumentwith some feedback to mitigate the issue introduced in #787 that made us realize that the order of the arguments in the signature was wrong