Add plain Gradient Descent optimizer #6459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
reviewed
May 26, 2021
jlapeyre
reviewed
May 28, 2021
| # pylint: disable=unused-argument | ||
| def optimize( | ||
| self, | ||
| num_vars, |
There was a problem hiding this comment.
Why not make num_vars optional, since it is unused? It is unused in the scipy optimizer, too (maybe others). Maybe fixing this in a uniform way is outside the scope of this PR.
There was a problem hiding this comment.
Excellent question, this is part of #6382 🙂
jlapeyre
reviewed
May 28, 2021
jlapeyre
approved these changes
Jun 1, 2021
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* implement plain Gradient Descent optimizer * replace leftover "SPSA" -> "GradientDescent" * update docstring in init * lint * add a proper docstring with examples * add callback test, mark slow test as slow_test * add reno * add test for learning rate as iterator * add stepsize to callback * Update qiskit/algorithms/optimizers/gradient_descent.py Add copyright * fix SPSA -> Gradient descent in docstrings Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* implement plain Gradient Descent optimizer * replace leftover "SPSA" -> "GradientDescent" * update docstring in init * lint * add a proper docstring with examples * add callback test, mark slow test as slow_test * add reno * add test for learning rate as iterator * add stepsize to callback * Update qiskit/algorithms/optimizers/gradient_descent.py Add copyright * fix SPSA -> Gradient descent in docstrings Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a plain gradient descent optimizer.
Details and comments
Any collection of optimizers need a standard gradient descent scheme, at least for reference! 🙂 (And I need it for the QML summer school.)
Todo: