Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Optimizer interface #6382

Closed
Cryoris opened this issue May 10, 2021 · 0 comments · Fixed by #6866
Closed

Refactor the Optimizer interface #6382

Cryoris opened this issue May 10, 2021 · 0 comments · Fixed by #6866
Assignees
@Cryoris
Labels
mod: algorithms Related to the Algorithms module
Milestone
0.19

Comments

@Cryoris
Copy link
Contributor

Cryoris commented May 10, 2021

What is the expected enhancement?

Mimic the common structure of minimization routines (like SciPy or scikit-quant) and change the "main" method of Optimizer.optimize to

minimize(f, x0=None, jac=None, hess=None, callback=None)

This also makes clear that our optimizers minimize something instead of just saying they optimize.

Since we don't use the same function name as before we can gracefully deprecate the old "main" method.
@Cryoris Cryoris added type: enhancement It's working, but needs polishing mod: algorithms Related to the Algorithms module and removed type: enhancement It's working, but needs polishing labels May 10, 2021
This was referenced May 10, 2021
Closed
Closed
@Cryoris Cryoris self-assigned this May 10, 2021
@Cryoris Cryoris mentioned this issue May 29, 2021
Merged
3 tasks
@Cryoris Cryoris added this to the 0.19 milestone Aug 3, 2021
@Cryoris Cryoris mentioned this issue Aug 4, 2021
Merged
@kdk kdk closed this as completed in #6866 Sep 8, 2021
This was referenced Sep 13, 2021
Merged
Closed
adekusar-drl added a commit to qiskit-community/qiskit-machine-learning that referenced this issue Sep 13, 2021
@adekusar-drl
replace optimize with minimize (#211)
673140c 
This is a follow up PR to make use of the changes introduced in Qiskit/qiskit#6382.
The Optimizer.optimize() method is deprecated in favor of Optimizer.minimize() and this is fixed in this PR.
gentinettagian pushed a commit to gentinettagian/qiskit-machine-learning that referenced this issue Dec 14, 2021
@adekusar-drl
replace optimize with minimize (qiskit-community#211)
83217aa 
This is a follow up PR to make use of the changes introduced in Qiskit/qiskit#6382.
The Optimizer.optimize() method is deprecated in favor of Optimizer.minimize() and this is fixed in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cryoris Cryoris

Labels
mod: algorithms Related to the Algorithms module
Projects
None yet
Milestone
0.19
Development

Successfully merging a pull request may close this issue.

Replace Optimizer.optimize by Optimizer.minimize Cryoris/qiskit-terra
1 participant
@Cryoris