Remove deprecated features in 0.46 in primitives #11576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates the unnecessary base class BasePrimitiveResult so we can have a clean break in defining new ones in Qiskit 1.0. Also deprecates the common utility methods `decompose`, `experiments`, and `num_experimetns` this base class adds to SamplerResult and EstimatorResult. Add jakes suggestion
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7744270839
💛 - Coveralls |
Cryoris
reviewed
Jan 17, 2024
| raise ValueError("Inconsistent number of experiments across data fields.") | ||
|
|
||
| @property # TODO: functools.cached_property when py37 is droppped |
There was a problem hiding this comment.
In case someone stumbles over this (like I did): these are removed w/o deprecation warning since the deprecation PR went into stable/0.46 directly -- as is the change from BasePrimitiveResult to _BasePrimitiveResult.
There was a problem hiding this comment.
yes, introduced by #11054
ikkoham
commented
Jan 30, 2024
| @@ -61,7 +61,7 @@ def init_observable(observable: BaseOperator | str) -> SparsePauliOp: | |||
| if isinstance(observable, SparsePauliOp): | |||
| return observable | |||
| elif isinstance(observable, BaseOperator) and not isinstance(observable, BasePauli): | |||
| return SparsePauliOp.from_operator(observable) | |||
| raise QiskitError(f"observable type not supported: {type(observable)}") | |||
There was a problem hiding this comment.
This was directly introduced into 0.46: #11535
ihincks
approved these changes
Feb 1, 2024
chriseclectic
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the deprecations introduced by #11052, #11051, #11054 and #11535
Details and comments
I'll add reno → done